Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4114)

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 15003002: Omnibox refactor. Move StartAutocomplete and DoInstant to controller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: FIxed NIT Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | chrome/browser/ui/omnibox/omnibox_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
index d38160e5283f4b79758bfcdfa6fb1d3d55835717..a3ae0c12fa5d2988616f296abe31448c5d3c3e31 100644
--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
@@ -1170,7 +1170,7 @@ void OmniboxViewGtk::HandleViewMoveCursor(
OnAfterPossibleChange();
handled = true;
} else if (count == count_towards_end && !IsCaretAtEnd()) {
- handled = model()->CommitSuggestedText(true);
+ handled = model()->CommitSuggestedText();
}
} else if (step == GTK_MOVEMENT_PAGES) { // Page up and down.
// Multiply by count for the direction (if we move too much that's ok).
@@ -1549,7 +1549,7 @@ void OmniboxViewGtk::HandleViewMoveFocus(GtkWidget* widget,
handled = true;
if (!handled && gtk_widget_get_visible(instant_view_))
- handled = model()->CommitSuggestedText(true);
+ handled = model()->CommitSuggestedText();
if (handled) {
static guint signal_id = g_signal_lookup("move-focus", GTK_TYPE_WIDGET);
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | chrome/browser/ui/omnibox/omnibox_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698