[android_webview] Add a command line setter tool.

[android_webview] Add a command line setter tool.

This adds a command line setter tool very similar to the ones already
present for content shell and testshell.

BUG=None
TESTS=None
NOTRY=true
R=benm@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200775

[joth, 2013-05-16 17:34:00]

lgtm





On 16 May 2013 10:31, <mkosiba@chromium.org> wrote:

> Reviewers: benm,
>
> Description:
> [android_webview] Add a command line setter tool.
>
> This adds a command line setter tool very similar to the ones already
> present for content shell and testshell.
>
> BUG=None
> TESTS=None
> NOTRY=true
> R=benm@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/15002006/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M android_webview/test/shell/**src/org/chromium/android_**webview/shell/
> **AwShellApplication.java
>   A + build/android/adb_android_**webview_command_line
>
>
> Index: android_webview/test/shell/**src/org/chromium/android_**
> webview/shell/**AwShellApplication.java
> diff --git a/android_webview/test/shell/**src/org/chromium/android_**
> webview/shell/**AwShellApplication.java b/android_webview/test/shell/**
> src/org/chromium/android_**webview/shell/**AwShellApplication.java
> index bac071fe1f295866b0a6b7db013f00**3921cf1480..**
> b1d0757f21a531cb1514b181c2ae9b**2e4a2bc24c 100644
> --- a/android_webview/test/shell/**src/org/chromium/android_**
> webview/shell/**AwShellApplication.java
> +++ b/android_webview/test/shell/**src/org/chromium/android_**
> webview/shell/**AwShellApplication.java
> @@ -27,7 +27,7 @@ public class AwShellApplication extends Application {
>
>          AwShellResourceProvider.**registerResources(this);
>
> -        CommandLine.initFromFile("/**data/local/chrome-command-**line");
> +        CommandLine.initFromFile("/**data/local/tmp/android-**
> webview-command-line");
>
>          if
(CommandLine.getInstance().**hasSwitch(CommandLine.WAIT_**FOR_JAVA_DEBUGGER))
> {
>             Log.e(TAG, "Waiting for Java debugger to connect...");
> Index: build/android/adb_android_**webview_command_line
> diff --git a/build/android/adb_content_**shell_command_line
> b/build/android/adb_android_**webview_command_line
> similarity index 77%
> copy from build/android/adb_content_**shell_command_line
> copy to build/android/adb_android_**webview_command_line
> index f3c1d4f49f2ff555c41eff41951aa4**5ff09aaa29..**
> 947cfb1eed7c39ed43a9c7dc4e8284**016c3140d8 100755
> --- a/build/android/adb_content_**shell_command_line
> +++ b/build/android/adb_android_**webview_command_line
> @@ -1,6 +1,6 @@
>  #!/bin/bash
>  #
> -# Copyright (c) 2012 The Chromium Authors. All rights reserved.
> +# Copyright (c) 2013 The Chromium Authors. All rights reserved.
>  # Use of this source code is governed by a BSD-style license that can be
>  # found in the LICENSE file.
>
> @@ -8,12 +8,12 @@
>  #
>  # Otherwise, the given flags are used to REPLACE (not modify) the content
> shell
>  # flags. For example:
> -#   adb_content_shell_command_line --enable-webgl
> +#   adb_android_webview_command_**line --enable-webgl
>  #
>  # To remove all content shell flags, pass an empty string for the flags:
> -#   adb_content_shell_command_line ""
> +#   adb_android_webview_command_**line ""
>
> -CMD_LINE_FILE=/data/local/**tmp/content-shell-command-line
> +CMD_LINE_FILE=/data/local/**tmp/android-webview-command-**line
>
>  if [ $# -eq 0 ] ; then
>    # If nothing specified, print the command line (stripping off
> "content_shell")
> @@ -30,7 +30,7 @@ elif [ $# -eq 1 ] && [ "$1" = '' ] ; then
>  else
>    # Else set it.
>    set -x
> -  adb shell "echo 'content_shell $*' > $CMD_LINE_FILE"
> +  adb shell "echo 'android_webview $*' > $CMD_LINE_FILE"
>    # Prevent other apps from modifying flags -- this can create security
> issues.
>    adb shell chmod 0664 $CMD_LINE_FILE
>  fi
>
>
>

[benm (inactive), 2013-05-16 17:40:10]

lgtm


On 16 May 2013 18:33, Jonathan Dixon <joth@chromium.org> wrote:

> lgtm
>
>
>
>
>
> On 16 May 2013 10:31, <mkosiba@chromium.org> wrote:
>
>> Reviewers: benm,
>>
>> Description:
>> [android_webview] Add a command line setter tool.
>>
>> This adds a command line setter tool very similar to the ones already
>> present for content shell and testshell.
>>
>> BUG=None
>> TESTS=None
>> NOTRY=true
>> R=benm@chromium.org
>>
>> Please review this at
https://chromiumcodereview.**appspot.com/15002006/<https://chromiumcodereview...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>   M android_webview/test/shell/**src/org/chromium/android_**
>> webview/shell/**AwShellApplication.java
>>   A + build/android/adb_android_**webview_command_line
>>
>>
>> Index: android_webview/test/shell/**src/org/chromium/android_**
>> webview/shell/**AwShellApplication.java
>> diff --git a/android_webview/test/shell/**src/org/chromium/android_**
>> webview/shell/**AwShellApplication.java b/android_webview/test/shell/**
>> src/org/chromium/android_**webview/shell/**AwShellApplication.java
>> index bac071fe1f295866b0a6b7db013f00**3921cf1480..**
>> b1d0757f21a531cb1514b181c2ae9b**2e4a2bc24c 100644
>> --- a/android_webview/test/shell/**src/org/chromium/android_**
>> webview/shell/**AwShellApplication.java
>> +++ b/android_webview/test/shell/**src/org/chromium/android_**
>> webview/shell/**AwShellApplication.java
>> @@ -27,7 +27,7 @@ public class AwShellApplication extends Application {
>>
>>          AwShellResourceProvider.**registerResources(this);
>>
>> -        CommandLine.initFromFile("/**data/local/chrome-command-**line");
>> +        CommandLine.initFromFile("/**data/local/tmp/android-**
>> webview-command-line");
>>
>>          if
(CommandLine.getInstance().**hasSwitch(CommandLine.WAIT_**FOR_JAVA_DEBUGGER))
>> {
>>             Log.e(TAG, "Waiting for Java debugger to connect...");
>> Index: build/android/adb_android_**webview_command_line
>> diff --git a/build/android/adb_content_**shell_command_line
>> b/build/android/adb_android_**webview_command_line
>> similarity index 77%
>> copy from build/android/adb_content_**shell_command_line
>> copy to build/android/adb_android_**webview_command_line
>> index f3c1d4f49f2ff555c41eff41951aa4**5ff09aaa29..**
>> 947cfb1eed7c39ed43a9c7dc4e8284**016c3140d8 100755
>> --- a/build/android/adb_content_**shell_command_line
>> +++ b/build/android/adb_android_**webview_command_line
>> @@ -1,6 +1,6 @@
>>  #!/bin/bash
>>  #
>> -# Copyright (c) 2012 The Chromium Authors. All rights reserved.
>> +# Copyright (c) 2013 The Chromium Authors. All rights reserved.
>>  # Use of this source code is governed by a BSD-style license that can be
>>  # found in the LICENSE file.
>>
>> @@ -8,12 +8,12 @@
>>  #
>>  # Otherwise, the given flags are used to REPLACE (not modify) the
>> content shell
>>  # flags. For example:
>> -#   adb_content_shell_command_line --enable-webgl
>> +#   adb_android_webview_command_**line --enable-webgl
>>  #
>>  # To remove all content shell flags, pass an empty string for the flags:
>> -#   adb_content_shell_command_line ""
>> +#   adb_android_webview_command_**line ""
>>
>> -CMD_LINE_FILE=/data/local/**tmp/content-shell-command-line
>> +CMD_LINE_FILE=/data/local/**tmp/android-webview-command-**line
>>
>>  if [ $# -eq 0 ] ; then
>>    # If nothing specified, print the command line (stripping off
>> "content_shell")
>> @@ -30,7 +30,7 @@ elif [ $# -eq 1 ] && [ "$1" = '' ] ; then
>>  else
>>    # Else set it.
>>    set -x
>> -  adb shell "echo 'content_shell $*' > $CMD_LINE_FILE"
>> +  adb shell "echo 'android_webview $*' > $CMD_LINE_FILE"
>>    # Prevent other apps from modifying flags -- this can create security
>> issues.
>>    adb shell chmod 0664 $CMD_LINE_FILE
>>  fi
>>
>>
>>
>

[commit-bot: I haz the power, 2013-05-17 09:35:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/15002006/1

[commit-bot: I haz the power, 2013-05-17 09:36:28]

Change committed as 200775