Deprecate the unofficial -webkit-transition media feature

Deprecate the unofficial -webkit-transition media feature because of two reasons:

1) It's prefixed and transitions are now unprefixed.
2) Authors can accomplish the same using CSS conditionals.

Measure usage and add a deprecation warning to the console.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150503

[Use mkwst_at_chromium.org plz., 2013-05-13 13:59:03]

LGTM, assuming the API owners CCd are happy.

It would be nice to throw deprecation warnings on the prefixed variant.

[kenneth.r.christiansen, 2013-05-13 14:41:16]

> It would be nice to throw deprecation warnings on the prefixed variant.

Done

[Use mkwst_at_chromium.org plz., 2013-05-13 14:43:20]

https://codereview.chromium.org/15001026/diff/4001/Source/core/css/MediaQuery...
File Source/core/css/MediaQueryEvaluator.cpp (right):

https://codereview.chromium.org/15001026/diff/4001/Source/core/css/MediaQuery...
Source/core/css/MediaQueryEvaluator.cpp:569:
frame->document()->addConsoleMessage(CSSMessageSource, DebugMessageLevel,
Please use UseCounter::countDeprecation instead, as outlined on
https://sites.google.com/a/chromium.org/dev/blink?pli=1#TOC-Launch-Process:-D...

[kenneth.r.christiansen, 2013-05-13 15:05:14]

> Please use UseCounter::countDeprecation instead...

Done

[Mike West, 2013-05-13 15:11:51]

https://codereview.chromium.org/15001026/diff/8001/Source/core/css/MediaQuery...
File Source/core/css/MediaQueryEvaluator.cpp (right):

https://codereview.chromium.org/15001026/diff/8001/Source/core/css/MediaQuery...
Source/core/css/MediaQueryEvaluator.cpp:559:
UseCounter::count(frame->document(),
UseCounter::PrefixedTransitionMediaFeature);
This is unprefixed, right? You'll need to have two items in the enum. :)

https://codereview.chromium.org/15001026/diff/8001/Source/core/page/UseCounter.h
File Source/core/page/UseCounter.h (right):

https://codereview.chromium.org/15001026/diff/8001/Source/core/page/UseCounte...
Source/core/page/UseCounter.h:134: PrefixedTransitionMediaFeature,
"UnprefixedTeansition..." as well. :)

[kenneth.r.christiansen, 2013-05-13 15:29:15]

> "UnprefixedTeansition..." as well. :)

Yeah I figured that during upload :-) Fixed now!

[Mike West, 2013-05-13 15:31:34]

Love it. LGTM again.

[eseidel, 2013-05-13 19:23:10]

What's the spec status?  Implementation of other browsers?  Should we be
exposing the unprefixed version at runtime?

[kenneth.christiansen, 2013-05-13 19:34:09]

On 2013/05/13 19:23:10, Eric Seidel wrote:
> What's the spec status?  Implementation of other browsers?  Should we be
> exposing the unprefixed version at runtime?

We are already shipping unprefixed transition in the rest of CSS, but Alexis
misses the media queries.

According to http://caniuse.com/css-transitions CSS 3 Transitions are unprefixed
in Firefox, IE and Opera (as well as Chrome but with the media query feature
missing)

[eseidel, 2013-05-14 09:01:36]

lgtm

[commit-bot: I haz the power, 2013-05-14 09:01:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15001...

[PhistucK, 2013-05-14 13:25:44]

On 2013/05/14 09:01:36, Eric Seidel wrote:
> lgtm

Wait!
Is this a standard feature at all? I am not sure any specification actually
defines those media query features. I think they are nonstandard and should
either be discouraged or standardized.

A quick search -
https://www.google.com/search?q=inurl:w3.org%2Ftr%2F+%22%40media+*+transition%22

Had no relevant result, so I just assume this is nonstandard.

Please, post to blink-dev so we could discuss this feature. I think it should be
deprecated and removed instead of getting unprefixed.

[kenneth.christiansen, 2013-05-14 13:36:29]

Actually I think you might have a valid point, I guess @support is supposed to
be the proper way to "unprefix" this. Removing from cq.

[PhistucK, 2013-05-14 13:41:06]

On 2013/05/14 13:36:29, kenneth.christiansen wrote:
> Actually I think you might have a valid point, I guess @support is supposed to
> be the proper way to "unprefix" this. Removing from cq.

On 2013/05/14 13:36:29, kenneth.christiansen wrote:
> Actually I think you might have a valid point, I guess @support is supposed to
> be the proper way to "unprefix" this. Removing from cq.

My thought exactly. :)
Great!

Thank you.

However, I still think we should count the usage of this. I only found three
articles that actually suggest using this media query. I think even the prefixed
one should be removed, but we do need to make sure we are not breaking many
websites (though I really doubt it).

[PhistucK, 2013-05-14 15:09:42]

Yay! Thank you for the updated patch set.

Eric, perhaps we should just remove those and look out for canary breakage?

[kenneth.r.christiansen, 2013-05-14 18:02:50]

> Eric, perhaps we should just remove those and look out for canary breakage?

I prefer measuring. We can always remove it later after a couple of releases.

[eseidel, 2013-05-14 18:25:56]

I don't have enough context to guide you one way or the other.  I'm OK with
measuring or not.  If we meaured we need to make it clear what code is deprected
so it's easy for someone to remove later.

[kenneth.r.christiansen, 2013-05-14 18:27:12]

On 2013/05/14 18:25:56, Eric Seidel wrote:
> I don't have enough context to guide you one way or the other.  I'm OK with
> measuring or not.  If we meaured we need to make it clear what code is
deprected
> so it's easy for someone to remove later.

That is why the method is prefixed with deprecated* in the patch.

[commit-bot: I haz the power, 2013-05-16 09:14:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15001...

[commit-bot: I haz the power, 2013-05-16 09:14:58]

Failed to apply patch for Source/core/css/MediaFeatureNames.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/MediaFeatureNames.h
  Hunk #2 FAILED at 67.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/MediaFeatureNames.h.rej

Patch:       Source/core/css/MediaFeatureNames.h
Index: Source/core/css/MediaFeatureNames.h
diff --git a/Source/core/css/MediaFeatureNames.h
b/Source/core/css/MediaFeatureNames.h
index
78c8f193e6250950c2b7385ce61bd89ea9073ba5..7c300eba398d450333d572e31802fc8b1723ae6f
100644
--- a/Source/core/css/MediaFeatureNames.h
+++ b/Source/core/css/MediaFeatureNames.h
@@ -27,6 +27,7 @@ namespace WebCore {
 namespace MediaFeatureNames {
 
 #define CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(macro) \
+    macro(deprecatedTransition, "-webkit-transition") \
     macro(color, "color") \
     macro(colorIndex, "color-index") \
     macro(grid, "grid") \
@@ -66,7 +67,6 @@ namespace MediaFeatureNames {
     macro(resolution, "resolution") \
     macro(transform2d, "-webkit-transform-2d") \
     macro(transform3d, "-webkit-transform-3d") \
-    macro(transition, "-webkit-transition") \
     macro(animation, "-webkit-animation") \
     macro(viewMode, "-webkit-view-mode")

[commit-bot: I haz the power, 2013-05-16 09:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15001...

[commit-bot: I haz the power, 2013-05-16 10:52:39]

Change committed as 150503