Allow pages on the OSX app launcher to be turned while dragging.

Allow pages on the OSX app launcher to be turned while dragging.

Adds an interface to the AppsGridController to optionally trigger a
page scroll after a delay, when given a drag location. Scrolling is
triggered if the point is to either side of the grid view, or over a
pager segment.

BUG=138633
TEST=Added: app_list_unittests AppsGridControllerTest.ScrollingWhileDragging.
Manually, test by dragging items on the OSX app launcher past the left
or right side, or over a pager segment, to initiate page scrolling
after a 1 second delay.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200987

[tapted, 2013-05-17 04:24:15]

Hi sail, could you take a look?

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
File ui/app_list/cocoa/app_list_view_controller.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
ui/app_list/cocoa/app_list_view_controller.mm:53: - (BOOL)isFlipped {
note: this keeps things consistent w.r.t. the drag animations (since this view
is now the superview to ensure things are not drawn over the ItemDragView). As a
bonus, the layout logic is a bit simpler here too.

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
File ui/app_list/cocoa/app_list_view_controller_unittest.mm (left):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
ui/app_list/cocoa/app_list_view_controller_unittest.mm:61: [AppsGridController
setScrollAnimationDuration:0.0];
note: moved to AppsGridControllerTestHelper() constructor

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
File ui/app_list/cocoa/apps_grid_controller.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
ui/app_list/cocoa/apps_grid_controller.mm:36: const NSTimeInterval
kScrollWhileDraggingDelay = 1.0;
note: value from apps_grid_view.cc (1000ms)

[sail, 2013-05-17 19:16:13]

lgtm

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
File ui/app_list/cocoa/app_list_pager_view.h (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
ui/app_list/cocoa/app_list_pager_view.h:39: -
(NSInteger)getSegmentAndHighlight:(NSPoint)locationInWindow;
Maybe name this: findAndHighlightSegmentAtLocation:

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_col...
File ui/app_list/cocoa/apps_collection_view_drag_manager.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_col...
ui/app_list/cocoa/apps_collection_view_drag_manager.mm:187: - (void)cancelDrag {
do you also need a cancelScrollTimer here?

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
File ui/app_list/cocoa/apps_grid_controller.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
ui/app_list/cocoa/apps_grid_controller.mm:260: if (pointInView.x < 0 ||
pointInView.x > [[self view] bounds].size.width) {
NSWidth
also should it be >=?

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
File ui/app_list/cocoa/apps_grid_controller_unittest.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
ui/app_list/cocoa/apps_grid_controller_unittest.mm:711: NSEvent*
MouseEventForScroll(NSView* view, CGFloat relative_x) {
move to top of file?

[tapted, 2013-05-17 23:25:29]

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
File ui/app_list/cocoa/app_list_pager_view.h (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/app_list...
ui/app_list/cocoa/app_list_pager_view.h:39: -
(NSInteger)getSegmentAndHighlight:(NSPoint)locationInWindow;
On 2013/05/17 19:16:13, sail wrote:
> Maybe name this: findAndHighlightSegmentAtLocation:

Done.

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_col...
File ui/app_list/cocoa/apps_collection_view_drag_manager.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_col...
ui/app_list/cocoa/apps_collection_view_drag_manager.mm:187: - (void)cancelDrag {
On 2013/05/17 19:16:13, sail wrote:
> do you also need a cancelScrollTimer here?

Thanks for checking! I had a look - updateDrag (which calls
maybeChangePageForPoint) is private and only called when dragging_ == YES, so
the timer cancel should reliably occur in completeDrag. I think if it were
needed here, there would be worse things happening..

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
File ui/app_list/cocoa/apps_grid_controller.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
ui/app_list/cocoa/apps_grid_controller.mm:260: if (pointInView.x < 0 ||
pointInView.x > [[self view] bounds].size.width) {
On 2013/05/17 19:16:13, sail wrote:
> NSWidth

Done.

> also should it be >=?

Yes! Thanks. You're right - the cursor might not always be able to go beyond the
view bounds. Done.

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
File ui/app_list/cocoa/apps_grid_controller_unittest.mm (right):

https://codereview.chromium.org/14999013/diff/6001/ui/app_list/cocoa/apps_gri...
ui/app_list/cocoa/apps_grid_controller_unittest.mm:711: NSEvent*
MouseEventForScroll(NSView* view, CGFloat relative_x) {
On 2013/05/17 19:16:13, sail wrote:
> move to top of file?

Done.

[commit-bot: I haz the power, 2013-05-17 23:26:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tapted@chromium.org/14999013/14001

[commit-bot: I haz the power, 2013-05-18 09:31:32]

Change committed as 200987