src/gpu/gl/GrGLProgramDesc.cpp - Issue 14998007: Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or frag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLProgramDesc.cpp

Issue 14998007: Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or frag (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Address comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/gl/GrGLProgramDesc.cpp

diff --git a/src/gpu/gl/GrGLProgramDesc.cpp b/src/gpu/gl/GrGLProgramDesc.cpp

index 1ae6aa69f2081d37e56d2b3cffa7c39de71edadf..a1cd85e9f4afb6d5ad2770fd9ac03a50292ccdca 100644

--- a/src/gpu/gl/GrGLProgramDesc.cpp

+++ b/src/gpu/gl/GrGLProgramDesc.cpp

@@ -87,7 +87,7 @@ void GrGLProgramDesc::Build(const GrDrawState& drawState,

const GrBackendEffectFactory& factory = effect->getFactory();

GrDrawEffect drawEffect(drawState.getStage(s), requiresLocalCoordAttrib);

desc->fEffectKeys[s] = factory.glEffectKey(drawEffect, gpu->glCaps());

- if (effect->willReadDst()) {

+ if (effect->willReadDstColor()) {

readsDst = true;

}

} else {

« no previous file with comments | « src/gpu/GrDrawState.h ('k') | src/gpu/gl/GrGLShaderBuilder.cpp » ('j') | no next file with comments »