src/core/SkXfermode.cpp - Issue 14998007: Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or frag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkXfermode.cpp

Issue 14998007: Make GrGLShaderBuilder check whether GrEffect advertised that it would require the dst color or frag (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Address comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkXfermode.cpp

diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp

index eb03ef958568919ff4e19f58170d9c37063389a5..7896061486df1e1bdc234fc16e7ea5549a91ebb1 100644

--- a/src/core/SkXfermode.cpp

+++ b/src/core/SkXfermode.cpp

@@ -1358,7 +1358,7 @@ public:

GR_DECLARE_EFFECT_TEST;

private:

- XferEffect(SkXfermode::Mode mode) : fMode(mode) { this->setWillReadDst(); }

+ XferEffect(SkXfermode::Mode mode) : fMode(mode) { this->setWillReadDstColor(); }

virtual bool onIsEqual(const GrEffect& other) const SK_OVERRIDE { return true; }

SkXfermode::Mode fMode;

« no previous file with comments | « include/gpu/GrEffect.h ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »