Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 14998005: HashTraits<RefPtr<P> >::peek should consider empty value (Closed)

Created:
7 years, 7 months ago by Mikhail
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, loislo+blink_chromium.org, jeez, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HashTraits<RefPtr<P> >::peek should consider empty value HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is raw pointer equal to '0', and return it right away instead of converting it to RefPtr and invoking get(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/wtf/HashTraits.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mikhail
Hi, Could you please look at a HashMap<RefPtr>::get() improvement? Same patch for WebKit has landed ...
7 years, 7 months ago (2013-05-08 20:23:45 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-08 20:48:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/14998005/1
7 years, 7 months ago (2013-05-08 20:49:02 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 22:46:00 UTC) #4
Message was sent while issue was closed.
Change committed as 149988

Powered by Google App Engine
This is Rietveld 408576698