Issue 14996004: Track heap objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14996004: Track heap objects. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -19 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
	src/arm/stub-cache-arm.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+23 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/property-details.h	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
	src/x64/stub-cache-x64.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

danno

lgtm, although it would be great if you had more test coverage

7 years, 7 months ago (2013-05-10 16:06:19 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-10 17:18:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14625 (presubmit successful).