Source/core/html/HTMLSelectElement.cpp - Issue 14996003: Disabled select element should not fire onchange event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 14996003: Disabled select element should not fire onchange event. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test and moved the checks to RenderListBox Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/select/listbox-disabled-no-autoscroll-expected.html ('k') | Source/core/rendering/RenderListBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index fbcbd05bf207f4fc84f811297da34228cefbdf02..5767d025b444c05687f572eaa833dbe5b6765db0 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -640,8 +640,6 @@ void HTMLSelectElement::updateListBoxSelection(bool deselectOtherOptions)

void HTMLSelectElement::listBoxOnChange()

{

ASSERT(!usesMenuList() || m_multiple);

- if (isDisabledFormControl())

- return;

const Vector<HTMLElement*>& items = listItems();