Issue 14995003: Move the remainder of Archive loading from FrameLoader to DocumentLoader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14995003: Move the remainder of Archive loading from FrameLoader to DocumentLoader. (Closed)

Created:
7 years, 7 months ago by Nate Chapin

Modified:
7 years, 7 months ago

Reviewers:
abarth-chromium, eseidel

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move the remainder of Archive loading from FrameLoader to DocumentLoader. Currently, when loading a subframe, FrameLoader checks very early on whether this is a subframe of an archive and switches to an archive load. There's no obvious reason this is necessary, and checking for a subframe archive load much later allows us to make everything archive-related on DocumentLoader private. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149768

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -45 lines)			Patch
M	Source/core/loader/DocumentLoader.h	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View	1	2 chunks	+18 lines, -13 lines	0 comments	Download
M	Source/core/loader/FrameLoader.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/loader/FrameLoader.cpp	View		3 chunks	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/14995003/2001

7 years, 7 months ago (2013-05-06 18:40:32 UTC) #3

Message was sent while issue was closed.

Change committed as 149768

Expand Messages | Collapse Messages