Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14994006: Clean up #includes in generated header files (Closed)

Created:
7 years, 7 months ago by haraken
Modified:
7 years, 7 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, adamk+blink_chromium.org, Nate Chapin
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -110 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 14 chunks +44 lines, -63 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomNamedGetter.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
r? https://codereview.chromium.org/14994006/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm File Source/bindings/scripts/CodeGeneratorV8.pm (right): https://codereview.chromium.org/14994006/diff/1/Source/bindings/scripts/CodeGeneratorV8.pm#newcode439 Source/bindings/scripts/CodeGeneratorV8.pm:439: sub HeaderFilesForInterface Now all custom header includes are ...
7 years, 7 months ago (2013-05-16 01:09:48 UTC) #1
abarth-chromium
lgtm ok
7 years, 7 months ago (2013-05-16 02:01:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/14994006/1
7 years, 7 months ago (2013-05-16 02:01:15 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=8201
7 years, 7 months ago (2013-05-16 02:43:01 UTC) #4
haraken
Committed patchset #1 manually as r150473 (presubmit successful).
7 years, 7 months ago (2013-05-16 02:44:16 UTC) #5
haraken
Reverted in r150480. Looks like I removed headers too aggressively.
7 years, 7 months ago (2013-05-16 04:37:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/14994006/15001
7 years, 7 months ago (2013-05-16 04:45:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=8228
7 years, 7 months ago (2013-05-16 05:24:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/14994006/15001
7 years, 7 months ago (2013-05-16 05:51:16 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 06:25:28 UTC) #10
Message was sent while issue was closed. 
Change committed as 150490

Powered by Google App Engine
This is Rietveld 408576698