Issue 14991004: Fixes a crash bug of calling animator without check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14991004: Fixes a crash bug of calling animator without check. (Closed)

Created:
7 years, 7 months ago by Jun Mukai

Modified:
7 years, 7 months ago

Reviewers:
dewittj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes a crash bug of calling animator without check. BUG=239508 R=dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199426

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/message_center/views/message_center_view.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dewittj

lgtm - tried it out on Win7 on trunk, no crash on "Clear All" or ...

7 years, 7 months ago (2013-05-09 23:05:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14991004/1

7 years, 7 months ago (2013-05-09 23:06:58 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=146504

7 years, 7 months ago (2013-05-10 04:01:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14991004/1

7 years, 7 months ago (2013-05-10 05:58:57 UTC) #5

Message was sent while issue was closed.

Change committed as 199426

Expand Messages | Collapse Messages