Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 14989002: Splitting MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp (Closed)

Created:
7 years, 7 months ago by Tommy Widenflycht
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jeez
Visibility:
Public.

Description

Splitting MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp What one were two simple classes have grown and now needs a split into a header and a implementation file. These files will go through some work soon as well. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149778

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -105 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebMediaStreamTrack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/mediastream/MediaStreamComponent.h View 3 chunks +9 lines, -24 lines 0 comments Download
A Source/core/platform/mediastream/MediaStreamComponent.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M Source/core/platform/mediastream/MediaStreamDescriptor.h View 4 chunks +10 lines, -81 lines 0 comments Download
A Source/core/platform/mediastream/MediaStreamDescriptor.cpp View 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tommy Widenflycht
No other code changes.
7 years, 7 months ago (2013-05-06 12:32:41 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-06 18:54:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/14989002/4001
7 years, 7 months ago (2013-05-06 18:54:53 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 19:35:06 UTC) #4
Message was sent while issue was closed.
Change committed as 149778

Powered by Google App Engine
This is Rietveld 408576698