Issue 14987006: Remove the external protocol dialog black border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14987006: Remove the external protocol dialog black border. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
oshima, sky

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove the external protocol dialog black border. ExtensionInstallDialogView uses Widget::CreateWindowWithParent. Use DialogDelegate::CreateDialogWidget instead. Does not change the old-style appearance or behavior. See before/after pics (on Win) at http://crbug.com/166075#c68 (I can't trigger on CrOS ToT, oshima suspects a regression) Trigger the dialog on Win by clicking a URI like the "spotify:" one at: https://www.spotify.com/us/blog/archives/2008/01/14/linking-to-spotify/ BUG=166075 TEST=new-style external procol dialog does not have a black border. R=sky@chromium.org,oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200039

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/external_protocol_dialog.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/views/external_protocol_dialog.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/14987006/1

7 years, 7 months ago (2013-05-14 15:09:13 UTC) #4

Message was sent while issue was closed.

Change committed as 200039