Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 14987004: Switching CSS Variables over to RuntimeEnabledFeatures (Closed)

Created:
7 years, 7 months ago by alancutter (OOO until 2018)
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth_chromum.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org
Visibility:
Public.

Description

Switching CSS Variables over to RuntimeEnabledFeatures Taking the CSS Variables flag out of InternalSettings and Settings and using RuntimeEnabledFeatures instead. BUG=239748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -153 lines) Patch
M LayoutTests/css3/filters/reference-filter-update-after-remove.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/border-width.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/build-supports-variables.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/css/variables/calc.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/calc-inside-calc.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/calc-invalid-value.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/calc-invalid-variable.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/calc-negated-variable.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/calc-vw-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/variables/case-insensitive.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/colors-test.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/complex-cycle.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/computed-style.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/deferred-image-load-from-variable.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/variables/inherited-values.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/inline-styles.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/invalid-font-reference.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/variables/invalid-shorthand.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/invalid-value-list-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/variables/invalid-variable-value.html View 1 chunk +0 lines, -3 lines 0 comments Download
LayoutTests/fast/css/variables/multi-level-cycle.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/redefinition.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/root-background-size.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/variables/shorthand.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/simple-cycle.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/transform-test.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/undefined.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/use-before-defined.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/var-filter.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/variables/var-inside-box-reflect.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/variables/var-inside-pair.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/variables/var-inside-quad.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/variables/var-inside-shape.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/variables/var-inside-shorthand.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/variable-chain.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/variables/variable-unparseable-value-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/styles/variables/css-variables.html View 1 chunk +0 lines, -3 lines 0 comments Download
LayoutTests/inspector/styles/variables/css-variables-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/public/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.cpp View 6 chunks +2 lines, -10 lines 0 comments Download
M Source/core/css/CSSParserMode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/Settings.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/page/Settings.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 3 chunks +0 lines, -14 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alancutter (OOO until 2018)
This Chromium change MUST land before this patch can land in Blink: https://codereview.chromium.org/14683006/
7 years, 7 months ago (2013-05-10 08:07:38 UTC) #1
eseidel
lgtm
7 years, 7 months ago (2013-05-10 08:13:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/14987004/1
7 years, 7 months ago (2013-05-15 23:37:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=1079
7 years, 7 months ago (2013-05-16 00:04:53 UTC) #4
abarth-chromium
API change LGTM
7 years, 7 months ago (2013-05-16 00:42:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/14987004/1
7 years, 7 months ago (2013-05-16 00:43:24 UTC) #6
commit-bot: I haz the power
Change committed as 150468
7 years, 7 months ago (2013-05-16 01:35:10 UTC) #7
eseidel
fast/css/parsing-expr-error-recovery.html appears to hit an ASSERT in debug. This is the only change on the ...
7 years, 7 months ago (2013-05-16 05:03:14 UTC) #8
eseidel
7 years, 7 months ago (2013-05-16 05:13:44 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698