Issue 14980012: Recognize html whitespaces as separators for attribute selectors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14980012: Recognize html whitespaces as separators for attribute selectors. (Closed)

Created:
7 years, 7 months ago by rune

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Recognize html whitespaces as separators for attribute selectors. Used to only recognize 0x20 as a separator for attribute selector matching values in space separated lists. Now recognizes 0x09, 0x0a, 0x0c, 0x0d, and 0x20 as separators. BUG=239786 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150410

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
A	LayoutTests/fast/selectors/attr-list-01.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/selectors/attr-list-01-expected.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	4 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/14980012/1

7 years, 7 months ago (2013-05-15 07:33:42 UTC) #3

Message was sent while issue was closed.

Change committed as 150410

Expand Messages | Collapse Messages