Fix for issue 10395, call noSUchMethod if a method is not found when using the Dart C API.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
@@ skipping 3737 matching lines @@
   name = NewString("instanceMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   result = Dart_Invoke(instance, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("instance !!!", str);
 
   // Instance method, wrong arg count.
   EXPECT_ERROR(Dart_Invoke(instance, name, 2, bad_args),
-               "did not find instance method 'Methods.instanceMethod'");
+               "Class 'Methods' has no instance method 'instanceMethod'"
+               " with matching arguments");

[srdjan, 2013/05/06 16:10:41]

Please add a test with noSuchMethod to verify proper dispatch to noSuchMethod.

[siva, 2013/05/06 16:20:25]

I did add one, see below (InvokeNoSuchMethod). There is a class in there which
has a noSuchMethod method.

On 2013/05/06 16:10:41, srdjan wrote:

 
   name = PrivateLibName(lib, "_instanceMethod");
   EXPECT(Dart_IsError(Dart_Invoke(lib, name, 1, args)));
   EXPECT(Dart_IsError(Dart_Invoke(cls, name, 1, args)));
   result = Dart_Invoke(instance, name, 1, args);
   EXPECT_VALID(result);
   result = Dart_StringToCString(result, &str);
   EXPECT_STREQ("hidden instance !!!", str);
 
   // Inherited method.
@@ skipping 112 matching lines @@
                                    NewString("toString"),
                                    0,
                                    NULL);
   EXPECT_VALID(result);
   EXPECT(Dart_IsString(result));
 
   const char* value = "";
   EXPECT_VALID(Dart_StringToCString(result, &value));
   EXPECT_STREQ("null", value);
 
-  // Should throw a NullPointerException. Disabled due to bug 5415268.
-  /*
-    Dart_Handle function_name2 = NewString("NoNoNo");
-    result = Dart_Invoke(null_receiver,
-    function_name2,
-    number_of_arguments,
-    dart_arguments);
-    EXPECT(Dart_IsError(result));
-    EXPECT(Dart_ErrorHasException(result)); */
+  Dart_Handle function_name = NewString("NoNoNo");
+  result = Dart_Invoke(Dart_Null(),
+                       function_name,
+                       0,
+                       NULL);
+  EXPECT(Dart_IsError(result));
+  EXPECT(Dart_ErrorHasException(result));
+}
+
+
+TEST_CASE(InvokeNoSuchMethod) {
+  const char* kScriptChars =
+      "import 'dart:_collection-dev' as _collection_dev;\n"
+      "class Expect {\n"
+      "  static equals(a, b) {\n"
+      "    if (a != b) {\n"
+      "      throw 'not equal. expected: $a, got: $b';\n"
+      "    }\n"
+      "  }\n"
+      "}\n"
+      "class TestClass {\n"
+      "  static int fld1 = 0;\n"
+      "  void noSuchMethod(Invocation invocation) {\n"
+      "    var name = _collection_dev.Symbol.getName(invocation.memberName);\n"
+      "    if (name == 'fld') {\n"
+      "      Expect.equals(true, invocation.isGetter);\n"
+      "      Expect.equals(false, invocation.isMethod);\n"
+      "      Expect.equals(false, invocation.isSetter);\n"
+      "    } else if (name == 'setfld') {\n"
+      "      Expect.equals(true, invocation.isSetter);\n"
+      "      Expect.equals(false, invocation.isMethod);\n"
+      "      Expect.equals(false, invocation.isGetter);\n"
+      "    } else if (name == 'method') {\n"
+      "      Expect.equals(true, invocation.isMethod);\n"
+      "      Expect.equals(false, invocation.isSetter);\n"
+      "      Expect.equals(false, invocation.isGetter);\n"
+      "    }\n"
+      "    TestClass.fld1 += 1;\n"
+      "  }\n"
+      "  static void testMain() {\n"
+      "    return new TestClass();\n"
+      "  }\n"
+      "}\n";
+  Dart_Handle result;
+  Dart_Handle instance;
+  // Create a test library and Load up a test script in it.
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  Dart_Handle cls = Dart_GetClass(lib, NewString("TestClass"));
+  EXPECT_VALID(cls);
+
+  // Invoke a function which returns an object.
+  instance = Dart_Invoke(cls, NewString("testMain"), 0, NULL);
+  EXPECT_VALID(instance);
+
+  // Try to get a field that does not exist, should call noSuchMethod.
+  result = Dart_GetField(instance, NewString("fld"));
+  EXPECT_VALID(result);
+
+  // Try to set a field that does not exist, should call noSuchMethod.
+  result = Dart_SetField(instance, NewString("setfld"), Dart_NewInteger(13));
+  EXPECT_VALID(result);
+
+  // Try to invoke a method that does not exist, should call noSuchMethod.
+  result = Dart_Invoke(instance, NewString("method"), 0, NULL);
+  EXPECT_VALID(result);
+
+  result = Dart_GetField(cls, NewString("fld1"));
+  EXPECT_VALID(result);
+  int64_t value = 0;
+  result = Dart_IntegerToInt64(result, &value);
+  EXPECT_EQ(3, value);
 }
 
 
 TEST_CASE(Invoke_CrossLibrary) {
   const char* kLibrary1Chars =
       "library library1_name;\n"
       "void local() {}\n"
       "void _local() {}\n";
   const char* kLibrary2Chars =
       "library library2_name;\n"
@@ skipping 3704 matching lines @@
                                    NewString("main"),
                                    0,
                                    NULL);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(260, value);
 }
 
 }  // namespace dart