Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: webkit/quota/quota_database.cc

Issue 14976003: Histogram versions and extended error codes for SQLite databases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Oops - need old histograms for continuity. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/database/database_tracker.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/quota/quota_database.h" 5 #include "webkit/quota/quota_database.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 440
441 bool in_memory_only = db_file_path_.empty(); 441 bool in_memory_only = db_file_path_.empty();
442 if (!create_if_needed && 442 if (!create_if_needed &&
443 (in_memory_only || !file_util::PathExists(db_file_path_))) { 443 (in_memory_only || !file_util::PathExists(db_file_path_))) {
444 return false; 444 return false;
445 } 445 }
446 446
447 db_.reset(new sql::Connection); 447 db_.reset(new sql::Connection);
448 meta_table_.reset(new sql::MetaTable); 448 meta_table_.reset(new sql::MetaTable);
449 449
450 db_->set_error_histogram_name("Sqlite.Quota.Error"); 450 db_->set_histogram_tag("Quota");
451 451
452 bool opened = false; 452 bool opened = false;
453 if (in_memory_only) { 453 if (in_memory_only) {
454 opened = db_->OpenInMemory(); 454 opened = db_->OpenInMemory();
455 } else if (!file_util::CreateDirectory(db_file_path_.DirName())) { 455 } else if (!file_util::CreateDirectory(db_file_path_.DirName())) {
456 LOG(ERROR) << "Failed to create quota database directory."; 456 LOG(ERROR) << "Failed to create quota database directory.";
457 } else { 457 } else {
458 opened = db_->Open(db_file_path_); 458 opened = db_->Open(db_file_path_);
459 if (opened) 459 if (opened)
460 db_->Preload(); 460 db_->Preload();
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 if (lhs.origin < rhs.origin) return true; 652 if (lhs.origin < rhs.origin) return true;
653 if (rhs.origin < lhs.origin) return false; 653 if (rhs.origin < lhs.origin) return false;
654 if (lhs.type < rhs.type) return true; 654 if (lhs.type < rhs.type) return true;
655 if (rhs.type < lhs.type) return false; 655 if (rhs.type < lhs.type) return false;
656 if (lhs.used_count < rhs.used_count) return true; 656 if (lhs.used_count < rhs.used_count) return true;
657 if (rhs.used_count < lhs.used_count) return false; 657 if (rhs.used_count < lhs.used_count) return false;
658 return lhs.last_access_time < rhs.last_access_time; 658 return lhs.last_access_time < rhs.last_access_time;
659 } 659 }
660 660
661 } // quota namespace 661 } // quota namespace
OLDNEW
« no previous file with comments | « webkit/database/database_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698