Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 14973007: Auto-install/uninstall shared module dependencies for extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/installed_loader.cc
diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc
index 2fc4b46c78338b3c209c81c0c8c9caf58b27f342..ee65eda4b5823955b6dd3291918fa7258700288b 100644
--- a/chrome/browser/extensions/installed_loader.cc
+++ b/chrome/browser/extensions/installed_loader.cc
@@ -164,7 +164,6 @@ void InstalledLoader::LoadAllExtensions() {
std::vector<int> reload_reason_counts(NUM_MANIFEST_RELOAD_REASONS, 0);
bool should_write_prefs = false;
- int update_count = 0;
for (size_t i = 0; i < extensions_info->size(); ++i) {
ExtensionInfo* info = extensions_info->at(i).get();
@@ -174,31 +173,6 @@ void InstalledLoader::LoadAllExtensions() {
if (info->extension_location == Manifest::COMMAND_LINE)
continue;
- scoped_ptr<ExtensionInfo> pending_update(
- extension_prefs_->GetDelayedInstallInfo(info->extension_id));
- if (pending_update) {
- if (!extension_prefs_->FinishDelayedInstallInfo(info->extension_id))
- NOTREACHED();
-
- Version old_version;
- if (info->extension_manifest) {
- std::string version_str;
- if (info->extension_manifest->GetString(
- extension_manifest_keys::kVersion, &version_str)) {
- old_version = Version(version_str);
- }
- }
- base::MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&DispatchOnInstalledEvent, extension_service_->profile(),
- info->extension_id, old_version, false));
-
- info = extension_prefs_->GetInstalledExtensionInfo(
- info->extension_id).release();
- extensions_info->at(i).reset(info);
-
- update_count++;
- }
-
ManifestReloadReason reload_reason = ShouldReloadExtensionManifest(*info);
++reload_reason_counts[reload_reason];
UMA_HISTOGRAM_ENUMERATION("Extensions.ManifestReloadEnumValue",
@@ -255,8 +229,6 @@ void InstalledLoader::LoadAllExtensions() {
extension_service_->extensions()->size());
UMA_HISTOGRAM_COUNTS_100("Extensions.Disabled",
extension_service_->disabled_extensions()->size());
- UMA_HISTOGRAM_COUNTS_100("Extensions.UpdateOnLoad",
- update_count);
UMA_HISTOGRAM_TIMES("Extensions.LoadAllTime",
base::TimeTicks::Now() - start_time);
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/pending_extension_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698