Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: webkit/common/user_agent/webkit_user_agent.gypi

Issue 14973005: Generate and use LASTCHANGE for blink (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/export_tarball/export_tarball.py ('K') | « webkit/build/webkit_version.h.in ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/common/user_agent/webkit_user_agent.gypi
diff --git a/webkit/common/user_agent/webkit_user_agent.gypi b/webkit/common/user_agent/webkit_user_agent.gypi
index 61e88ea131222f8b4ac6f09d93faa9a9115f9fa9..306582522e96398b7ee7d49df409d77b5959f4c5 100644
--- a/webkit/common/user_agent/webkit_user_agent.gypi
+++ b/webkit/common/user_agent/webkit_user_agent.gypi
@@ -50,18 +50,22 @@
'action_name': 'webkit_version',
'inputs': [
'<(script)',
- '../../../build/util/lastchange.py', # Used by the script.
- # This depends on the svn revision of third_party/WebKit but does
- # not list it as a dependency. Incremental builds will have
- # the wrong WEBKIT_SVN_REVISION.
+ '<(lastchange)',
+ '<(template)',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/webkit_version.h',
],
- 'action': ['python', '<(script)', '../../../third_party/WebKit/Source',
- '<(SHARED_INTERMEDIATE_DIR)'],
+ 'action': ['python',
+ '<(script)',
+ '-f', '<(lastchange)',
+ '<(template)',
+ '<@(_outputs)',
+ ],
'variables': {
- 'script': '../build/webkit_version.py',
+ 'script': '<(DEPTH)/chrome/tools/build/version.py',
+ 'lastchange': '<(DEPTH)/build/util/LASTCHANGE.blink',
+ 'template': '<(DEPTH)/webkit/build/webkit_version.h.in',
},
},
],
« tools/export_tarball/export_tarball.py ('K') | « webkit/build/webkit_version.h.in ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698