Generate and use LASTCHANGE for blink

tools/export_tarball/export_tarball.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This tool creates a tarball with all the sources, but without .svn directories.
 
 It can also remove files which are not strictly required for build, so that
 the resulting tarball can be reasonably small (last time it was ~110 MB).
@@ skipping 116 matching lines @@
 
   if len(args) != 1:
     print 'You must provide only one argument: output file name'
     print '(without .tar.xz extension).'
     return 1
 
   if not os.path.exists(GetSourceDirectory()):
     print 'Cannot find the src directory ' + GetSourceDirectory()
     return 1
 
-  # This command is from src/DEPS; please keep them in sync.
+  # These two commands are from src/DEPS; please keep them in sync.
   if subprocess.call(['python', 'build/util/lastchange.py', '-o',
                       'build/util/LASTCHANGE'], cwd=GetSourceDirectory()) != 0:
     print 'Could not run build/util/lastchange.py to update LASTCHANGE.'
     return 1
+  if subprocess.call(['python', 'build/util/lastchange.py', '-s',
+                      'src/third_party/WebKit', '-o',

[Paweł Hajdan Jr., 2013/06/14 20:44:00]

Note: this broke the script (could be easily detected by running it:

$ tools/export_tarball/export_tarball.py foo
Traceback (most recent call last):
  File "build/util/lastchange.py", line 236, in <module>
    sys.exit(main())
  File "build/util/lastchange.py", line 228, in main
    WriteIfChanged(out_file, contents)
  File "build/util/lastchange.py", line 185, in WriteIfChanged
    open(file_name, 'w').write(contents)
IOError: [Errno 2] No such file or directory: 'src/build/util/LASTCHANGE.blink'
Could not run build/util/lastchange.py to update LASTCHANGE.blink.

I have a CL to fix it, https://codereview.chromium.org/17105005 . This is just
feedback to avoid similar mistakes in the future. Thanks!

+                      'src/build/util/LASTCHANGE.blink'],
+                     cwd=GetSourceDirectory()) != 0:
+    print 'Could not run build/util/lastchange.py to update LASTCHANGE.blink.'
+    return 1
 
   output_fullname = args[0] + '.tar'
   output_basename = options.basename or os.path.basename(args[0])
 
   archive = MyTarFile.open(output_fullname, 'w')
   archive.set_remove_nonessential_files(options.remove_nonessential_files)
   try:
     if options.test_data:
       for directory in TESTDIRS:
         archive.add(os.path.join(GetSourceDirectory(), directory),
                     arcname=os.path.join(output_basename, directory))
     else:
       archive.add(GetSourceDirectory(), arcname=output_basename)
   finally:
     archive.close()
 
   if subprocess.call(['xz', '-9', output_fullname]) != 0:
     print 'xz -9 failed!'
     return 1
 
   return 0
 
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))