Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 14972004: Fix overlapping labels in Files.app's gallery new UI. (Closed)

Created:
7 years, 7 months ago by mtomasz
Modified:
7 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix overlapping labels in Files.app's gallery new UI. The styles showing the labels when the page width is > 1000px was not overriding the original styles because the style had lower priority. This patch fixes this issue by adding a body prefix to the style declaration. TBR=yoshiki@chromium.org TEST=Launch Files.app, open a picture, try to edit. Be sure that the window is large enough to show the labels. BUG=235789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/css/gallery.css View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
7 years, 7 months ago (2013-05-07 02:15:35 UTC) #1
hirono
On 2013/05/07 02:15:35, mtomasz wrote: > @hirono: PTAL. Thanks. LGTM!
7 years, 7 months ago (2013-05-07 03:45:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14972004/1
7 years, 7 months ago (2013-05-07 03:47:36 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 13:15:09 UTC) #4
Message was sent while issue was closed.
Change committed as 198708

Powered by Google App Engine
This is Rietveld 408576698