Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & ios update Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index bc8b28ea482e0e82d5703d2ce17f8625bd6d47e7..a6062dbdf06679f35653ec54b95d74c7d18c9a0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -61,7 +61,6 @@ import org.chromium.chrome.browser.appmenu.AppMenuHandler;
import org.chromium.chrome.browser.appmenu.AppMenuObserver;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
import org.chromium.chrome.browser.bookmark.BookmarksBridge.BookmarkModelObserver;
-import org.chromium.chrome.browser.bookmark.ManageBookmarkActivity;
import org.chromium.chrome.browser.compositor.CompositorViewHolder;
import org.chromium.chrome.browser.compositor.layouts.Layout;
import org.chromium.chrome.browser.compositor.layouts.LayoutManager;
@@ -1026,38 +1025,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
// TODO(bauerb): This does not take partner bookmarks into account.
final long bookmarkId = tabToBookmark.getUserBookmarkId();
- if (EnhancedBookmarkUtils.isEnhancedBookmarkEnabled()) {
- final EnhancedBookmarksModel bookmarkModel = new EnhancedBookmarksModel();
- if (bookmarkModel.isBookmarkModelLoaded()) {
+ final EnhancedBookmarksModel bookmarkModel = new EnhancedBookmarksModel();
+ bookmarkModel.runAfterBookmarkModelLoaded(new Runnable() {
+ @Override
+ public void run() {
EnhancedBookmarkUtils.addOrEditBookmark(bookmarkId, bookmarkModel,
tabToBookmark, getSnackbarManager(), ChromeActivity.this);
- } else if (mBookmarkObserver == null) {
- mBookmarkObserver = new BookmarkModelObserver() {
- @Override
- public void bookmarkModelChanged() {}
-
- @Override
- public void bookmarkModelLoaded() {
- EnhancedBookmarkUtils.addOrEditBookmark(bookmarkId, bookmarkModel,
- tabToBookmark, getSnackbarManager(), ChromeActivity.this);
- bookmarkModel.removeObserver(this);
- }
- };
- bookmarkModel.addObserver(mBookmarkObserver);
}
- } else {
- Intent intent = new Intent(this, ManageBookmarkActivity.class);
- if (bookmarkId == ChromeBrowserProviderClient.INVALID_BOOKMARK_ID) {
- intent.putExtra(ManageBookmarkActivity.BOOKMARK_INTENT_IS_FOLDER, false);
- intent.putExtra(ManageBookmarkActivity.BOOKMARK_INTENT_TITLE,
- tabToBookmark.getTitle());
- intent.putExtra(ManageBookmarkActivity.BOOKMARK_INTENT_URL, tabToBookmark.getUrl());
- } else {
- intent.putExtra(ManageBookmarkActivity.BOOKMARK_INTENT_IS_FOLDER, false);
- intent.putExtra(ManageBookmarkActivity.BOOKMARK_INTENT_ID, bookmarkId);
- }
- startActivity(intent);
- }
+ });
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698