Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_features.cc

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & ios update Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/enhanced_bookmark_features.cc
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_features.cc b/components/enhanced_bookmarks/enhanced_bookmark_features.cc
deleted file mode 100644
index c2808c7593b685323206daeaf0a66158fb85f04c..0000000000000000000000000000000000000000
--- a/components/enhanced_bookmarks/enhanced_bookmark_features.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/enhanced_bookmarks/enhanced_bookmark_features.h"
-
-#include <string>
-
-#include "base/command_line.h"
-#include "build/build_config.h"
-#include "components/enhanced_bookmarks/enhanced_bookmark_switches.h"
-#include "components/offline_pages/offline_page_feature.h"
-#include "components/variations/variations_associated_data.h"
-
-#if defined(OS_IOS) || defined(OS_ANDROID)
-
-namespace enhanced_bookmarks {
-namespace {
-const char kFieldTrialName[] = "EnhancedBookmarks";
-} // namespace
-
-bool IsEnhancedBookmarksEnabled() {
-#if defined(OS_ANDROID)
- // If offline pages feature is enabled, also enable enhanced bookmarks feature
- // regardless its state.
- if (offline_pages::IsOfflinePagesEnabled())
- return true;
-#endif
-
- // kEnhancedBookmarksExperiment flag could have values "", "1" and "0". "" -
- // default, "0" - user opted out, "1" - user opted in. Tests also use the
- // command line flag to force enhanced bookmark to be on.
- std::string switch_value =
- base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
- switches::kEnhancedBookmarksExperiment);
- if (switch_value == "1")
- return true;
- if (switch_value == "0")
- return false;
-
- // Check that the "id" param is present. This is a legacy of the desktop
- // implementation providing the extension id via param. This probably should
- // be replaced with code that checks the experiment name instead.
- return !variations::GetVariationParamValue(kFieldTrialName, "id").empty();
-}
-
-} // namespace enhanced_bookmarks
-
-#endif
« no previous file with comments | « components/enhanced_bookmarks/enhanced_bookmark_features.h ('k') | components/enhanced_bookmarks/enhanced_bookmark_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698