Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Side by Side Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & ios update Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/enhanced_bookmarks.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h" 5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
11 #include "base/android/jni_string.h" 11 #include "base/android/jni_string.h"
12 #include "base/containers/stack_container.h" 12 #include "base/containers/stack_container.h"
13 #include "base/i18n/string_compare.h" 13 #include "base/i18n/string_compare.h"
14 #include "base/prefs/pref_service.h" 14 #include "base/prefs/pref_service.h"
15 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 15 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
16 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h" 16 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
17 #include "chrome/browser/profiles/incognito_helpers.h" 17 #include "chrome/browser/profiles/incognito_helpers.h"
18 #include "chrome/browser/profiles/profile.h" 18 #include "chrome/browser/profiles/profile.h"
19 #include "chrome/browser/profiles/profile_android.h" 19 #include "chrome/browser/profiles/profile_android.h"
20 #include "chrome/browser/signin/signin_manager_factory.h" 20 #include "chrome/browser/signin/signin_manager_factory.h"
21 #include "chrome/browser/undo/bookmark_undo_service_factory.h" 21 #include "chrome/browser/undo/bookmark_undo_service_factory.h"
22 #include "components/bookmarks/browser/bookmark_match.h" 22 #include "components/bookmarks/browser/bookmark_match.h"
23 #include "components/bookmarks/browser/bookmark_model.h" 23 #include "components/bookmarks/browser/bookmark_model.h"
24 #include "components/bookmarks/browser/bookmark_utils.h" 24 #include "components/bookmarks/browser/bookmark_utils.h"
25 #include "components/bookmarks/browser/scoped_group_bookmark_actions.h" 25 #include "components/bookmarks/browser/scoped_group_bookmark_actions.h"
26 #include "components/bookmarks/common/android/bookmark_type.h" 26 #include "components/bookmarks/common/android/bookmark_type.h"
27 #include "components/bookmarks/common/bookmark_pref_names.h" 27 #include "components/bookmarks/common/bookmark_pref_names.h"
28 #include "components/bookmarks/managed/managed_bookmark_service.h" 28 #include "components/bookmarks/managed/managed_bookmark_service.h"
29 #include "components/enhanced_bookmarks/enhanced_bookmark_features.h"
30 #include "components/query_parser/query_parser.h" 29 #include "components/query_parser/query_parser.h"
31 #include "components/signin/core/browser/signin_manager.h" 30 #include "components/signin/core/browser/signin_manager.h"
32 #include "components/undo/bookmark_undo_service.h" 31 #include "components/undo/bookmark_undo_service.h"
33 #include "components/undo/undo_manager.h" 32 #include "components/undo/undo_manager.h"
34 #include "content/public/browser/browser_thread.h" 33 #include "content/public/browser/browser_thread.h"
35 #include "grit/components_strings.h" 34 #include "grit/components_strings.h"
36 #include "jni/BookmarksBridge_jni.h" 35 #include "jni/BookmarksBridge_jni.h"
37 #include "ui/base/l10n/l10n_util.h" 36 #include "ui/base/l10n/l10n_util.h"
38 37
39 using base::android::AttachCurrentThread; 38 using base::android::AttachCurrentThread;
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 return RegisterNativesImpl(env); 136 return RegisterNativesImpl(env);
138 } 137 }
139 138
140 static jlong Init(JNIEnv* env, 139 static jlong Init(JNIEnv* env,
141 const JavaParamRef<jobject>& obj, 140 const JavaParamRef<jobject>& obj,
142 const JavaParamRef<jobject>& j_profile) { 141 const JavaParamRef<jobject>& j_profile) {
143 BookmarksBridge* delegate = new BookmarksBridge(env, obj, j_profile); 142 BookmarksBridge* delegate = new BookmarksBridge(env, obj, j_profile);
144 return reinterpret_cast<intptr_t>(delegate); 143 return reinterpret_cast<intptr_t>(delegate);
145 } 144 }
146 145
147 static jboolean IsEnhancedBookmarksFeatureEnabled(
148 JNIEnv* env,
149 const JavaParamRef<jclass>& clazz) {
150 return enhanced_bookmarks::IsEnhancedBookmarksEnabled();
151 }
152
153 jboolean BookmarksBridge::IsEditBookmarksEnabled( 146 jboolean BookmarksBridge::IsEditBookmarksEnabled(
154 JNIEnv* env, 147 JNIEnv* env,
155 const JavaParamRef<jobject>& obj) { 148 const JavaParamRef<jobject>& obj) {
156 return IsEditBookmarksEnabled(); 149 return IsEditBookmarksEnabled();
157 } 150 }
158 151
159 void BookmarksBridge::LoadEmptyPartnerBookmarkShimForTesting( 152 void BookmarksBridge::LoadEmptyPartnerBookmarkShimForTesting(
160 JNIEnv* env, 153 JNIEnv* env,
161 const JavaParamRef<jobject>& obj) { 154 const JavaParamRef<jobject>& obj) {
162 if (partner_bookmarks_shim_->IsLoaded()) 155 if (partner_bookmarks_shim_->IsLoaded())
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
789 DCHECK_CURRENTLY_ON(BrowserThread::UI); 782 DCHECK_CURRENTLY_ON(BrowserThread::UI);
790 DCHECK(IsLoaded()); 783 DCHECK(IsLoaded());
791 DCHECK(grouped_bookmark_actions_.get()); // should only call after start 784 DCHECK(grouped_bookmark_actions_.get()); // should only call after start
792 grouped_bookmark_actions_.reset(); 785 grouped_bookmark_actions_.reset();
793 } 786 }
794 787
795 base::string16 BookmarksBridge::GetTitle(const BookmarkNode* node) const { 788 base::string16 BookmarksBridge::GetTitle(const BookmarkNode* node) const {
796 if (partner_bookmarks_shim_->IsPartnerBookmark(node)) 789 if (partner_bookmarks_shim_->IsPartnerBookmark(node))
797 return partner_bookmarks_shim_->GetTitle(node); 790 return partner_bookmarks_shim_->GetTitle(node);
798 791
799 if (node == bookmark_model_->bookmark_bar_node() 792 if (node == bookmark_model_->bookmark_bar_node()) {
800 && enhanced_bookmarks::IsEnhancedBookmarksEnabled()) {
801 return l10n_util::GetStringUTF16(IDS_ENHANCED_BOOKMARK_BAR_FOLDER_NAME); 793 return l10n_util::GetStringUTF16(IDS_ENHANCED_BOOKMARK_BAR_FOLDER_NAME);
802 } 794 }
803 795
804 return node->GetTitle(); 796 return node->GetTitle();
805 } 797 }
806 798
807 ScopedJavaLocalRef<jobject> BookmarksBridge::CreateJavaBookmark( 799 ScopedJavaLocalRef<jobject> BookmarksBridge::CreateJavaBookmark(
808 const BookmarkNode* node) { 800 const BookmarkNode* node) {
809 JNIEnv* env = AttachCurrentThread(); 801 JNIEnv* env = AttachCurrentThread();
810 802
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
1098 BookmarkModelChanged(); 1090 BookmarkModelChanged();
1099 } 1091 }
1100 1092
1101 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) { 1093 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) {
1102 NotifyIfDoneLoading(); 1094 NotifyIfDoneLoading();
1103 } 1095 }
1104 1096
1105 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) { 1097 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) {
1106 partner_bookmarks_shim_ = NULL; 1098 partner_bookmarks_shim_ = NULL;
1107 } 1099 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/enhanced_bookmarks.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698