Issue 14969017: Cleanup and reduce memory usage for MultiChannelResampler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14969017: Cleanup and reduce memory usage for MultiChannelResampler. (Closed)

Created:
7 years, 7 months ago by DaleCurtis

Modified:
7 years, 7 months ago

Reviewers:
xhwang

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup and reduce memory usage for MultiChannelResampler. Removes a vector allocation and an allocation for an unused channel in favor of AudioBus::CreateWrapper(). These allocations are also moved to the constructor now that SincResampler will always ask for the same amount of data. BUG=none TEST=media_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199521

Patch Set 1 : Cleanup. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -31 lines)			Patch
	M	media/base/multi_channel_resampler.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
	M	media/base/multi_channel_resampler.cc	View		3 chunks	+19 lines, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

xhwang

Good chance to learn about the audio world! I don't fully understand this CL but ...

7 years, 7 months ago (2013-05-10 00:44:30 UTC) #2

DaleCurtis

Discussed offline and xhwang@ is comfortable with commit. Thanks for review! CQ'ing.

7 years, 7 months ago (2013-05-10 16:32:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/14969017/2001

7 years, 7 months ago (2013-05-10 16:32:21 UTC) #4

Message was sent while issue was closed.

Change committed as 199521

Expand Messages | Collapse Messages