Issue 14969008: Removes the space for notification icon if it's not visible (2nd)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14969008: Removes the space for notification icon if it's not visible (2nd) (Closed)

Created:
7 years, 7 months ago by Jun Mukai

Modified:
7 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removes the space for notification icon if it's not visible (2nd) GridLayout will make the space for a child even if the child is not visible, which makes an extra space between status area and panels when there are no notifications. To remove this space, this CL makes StatusAreaWidgetDelegate catch child's visibility change, and do not count invisible children in its GridLayout. The previous CL was reverted due to test break on win_aura. This CL includes its fix. BUG=238770 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199451

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -10 lines)			Patch
M	ash/system/status_area_widget_delegate.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ash/system/status_area_widget_delegate.cc	View		2 chunks	+22 lines, -5 lines	0 comments	Download
M	ash/wm/panels/panel_window_resizer_unittest.cc	View	1 2	5 chunks	+5 lines, -4 lines	0 comments	Download