Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14967003: Drop more dependencies of ProfileKeyedService infrastructure on chrome. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, shishir+watch_chromium.org, tzik+watch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org, sail+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, pam+watch_chromium.org, tfarina, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Drop more dependencies of ProfileKeyedService infrastructure on chrome. This extracts AssertFactoriesBuilt code to a file that will stay in chrome. BUG=227219 R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199566

Patch Set 1 #

Patch Set 2 : trybots #

Patch Set 3 : trybots #

Patch Set 4 : rebase #

Patch Set 5 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -431 lines) Patch
M apps/shortcut_manager_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_to_mobile_service_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/discovery/suggested_links_registry_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_manager_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/token_cache/token_cache_service_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_notification_manager_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/predictors/predictor_database_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A + chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 3 4 6 chunks +15 lines, -139 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.h View 5 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 7 chunks +13 lines, -270 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_keyed_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/global_error/global_error_service_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_resource_cache_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-08 23:03:09 UTC) #1
Elliot Glaysher
lgtm
7 years, 7 months ago (2013-05-08 23:09:13 UTC) #2
Paweł Hajdan Jr.
Elliot, could you take another look? While getting tests to pass I needed to make ...
7 years, 7 months ago (2013-05-10 20:56:47 UTC) #3
Elliot Glaysher
slgtm
7 years, 7 months ago (2013-05-10 21:07:08 UTC) #4
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-10 23:13:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r199566.

Powered by Google App Engine
This is Rietveld 408576698