Use the machine hostname on Linux machines for the sync session name rather than

Use the machine hostname on Linux machines for the sync session name rather than
the distro name, but retain distro name as a fallback in case the hostname
fails. Uses gethostname() from unistd.h.

BUG=123827
TEST=Verify on a Linux machine that the hostname apppears in
chrome://sync-internals > Sync Node Browser > Root > Device Information.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198704

[Aditya, 2013-05-04 16:15:04]

Hi all,

Rachel Popkin is owner of Chromium bug 123827 and she asked that I submit my
patch with you three listed as reviewers... so here we are :) I've gone through
the developer guidelines, etc. but I'm bound to have missed something; please
excuse me if I did!

Aditya

[Nicolas Zea, 2013-05-06 17:54:09]

Just a couple nits. Thanks for submitting this!

https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
File sync/util/get_session_name_linux.cc (right):

https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
sync/util/get_session_name_linux.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
here too

https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
sync/util/get_session_name_linux.cc:17: if (gethostname(hostname, HOST_NAME_MAX)
== 0)  // success
nit: "success" -> "Success."

https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
File sync/util/get_session_name_linux.h (right):

https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
sync/util/get_session_name_linux.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
nit: update to 2013

[Aditya, 2013-05-06 21:37:12]

On 2013/05/06 17:54:09, Nicolas Zea wrote:
> Just a couple nits. Thanks for submitting this!
> 
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> File sync/util/get_session_name_linux.cc (right):
> 
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> sync/util/get_session_name_linux.cc:1: // Copyright (c) 2012 The Chromium
> Authors. All rights reserved.
> here too
> 
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> sync/util/get_session_name_linux.cc:17: if (gethostname(hostname,
HOST_NAME_MAX)
> == 0)  // success
> nit: "success" -> "Success."
> 
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> File sync/util/get_session_name_linux.h (right):
> 
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> sync/util/get_session_name_linux.h:1: // Copyright (c) 2012 The Chromium
> Authors. All rights reserved.
> nit: update to 2013

Thanks Nicolas, I've made the appropriate adjustments. My understanding is that
once I get an LGTM from you I'm free to hit the commit button (even though I'm
an external contributor, that will work, or so say the contribution guidelines),
is that correct?

[Nicolas Zea, 2013-05-06 21:40:29]

On 2013/05/06 21:37:12, Aditya wrote:
> On 2013/05/06 17:54:09, Nicolas Zea wrote:
> > Just a couple nits. Thanks for submitting this!
> > 
> >
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> > File sync/util/get_session_name_linux.cc (right):
> > 
> >
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> > sync/util/get_session_name_linux.cc:1: // Copyright (c) 2012 The Chromium
> > Authors. All rights reserved.
> > here too
> > 
> >
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> > sync/util/get_session_name_linux.cc:17: if (gethostname(hostname,
> HOST_NAME_MAX)
> > == 0)  // success
> > nit: "success" -> "Success."
> > 
> >
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> > File sync/util/get_session_name_linux.h (right):
> > 
> >
>
https://codereview.chromium.org/14963003/diff/4002/sync/util/get_session_name...
> > sync/util/get_session_name_linux.h:1: // Copyright (c) 2012 The Chromium
> > Authors. All rights reserved.
> > nit: update to 2013
> 
> Thanks Nicolas, I've made the appropriate adjustments. My understanding is
that
> once I get an LGTM from you I'm free to hit the commit button (even though I'm
> an external contributor, that will work, or so say the contribution
guidelines),
> is that correct?

That's correct.

LGTM

[commit-bot: I haz the power, 2013-05-06 22:18:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/heuristicist@gmail.com/14963003/8001

[commit-bot: I haz the power, 2013-05-06 22:18:38]

Failed to apply patch for AUTHORS:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 249.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
===================================================================
--- AUTHORS	(revision 198306)
+++ AUTHORS	(working copy)
@@ -249,3 +249,4 @@
 Li Yin <li.yin@intel.com>
 Mihai Tica <mihai.o.tica@gmail.com>
 Mihai Tica <mitica@adobe.com>
+Aditya Bhargava <heuristicist@gmail.com>

[Aditya, 2013-05-06 22:57:39]

On 2013/05/06 22:18:38, I haz the power (commit-bot) wrote:
> Failed to apply patch for AUTHORS:
> While running patch -p0 --forward --force --no-backup-if-mismatch;
>   patching file AUTHORS
>   Hunk #1 FAILED at 249.
>   1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej
> 
> Patch:       AUTHORS
> Index: AUTHORS
> ===================================================================
> --- AUTHORS	(revision 198306)
> +++ AUTHORS	(working copy)
> @@ -249,3 +249,4 @@
>  Li Yin <mailto:li.yin@intel.com>
>  Mihai Tica <mailto:mihai.o.tica@gmail.com>
>  Mihai Tica <mailto:mitica@adobe.com>
> +Aditya Bhargava <mailto:heuristicist@gmail.com>

Looks like there was a new author so the patch failed. I've rebased my AUTHORS
file, I'd appreciate one more LGTM so I can commit the final version! (I assume
another reviewer-pass is necessary even for small changes like this---if not,
apologies for the additional email!)

[Nicolas Zea, 2013-05-06 23:12:33]

On 2013/05/06 22:57:39, Aditya wrote:
> On 2013/05/06 22:18:38, I haz the power (commit-bot) wrote:
> > Failed to apply patch for AUTHORS:
> > While running patch -p0 --forward --force --no-backup-if-mismatch;
> >   patching file AUTHORS
> >   Hunk #1 FAILED at 249.
> >   1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej
> > 
> > Patch:       AUTHORS
> > Index: AUTHORS
> > ===================================================================
> > --- AUTHORS	(revision 198306)
> > +++ AUTHORS	(working copy)
> > @@ -249,3 +249,4 @@
> >  Li Yin <mailto:li.yin@intel.com>
> >  Mihai Tica <mailto:mihai.o.tica@gmail.com>
> >  Mihai Tica <mailto:mitica@adobe.com>
> > +Aditya Bhargava <mailto:heuristicist@gmail.com>
> 
> Looks like there was a new author so the patch failed. I've rebased my AUTHORS
> file, I'd appreciate one more LGTM so I can commit the final version! (I
assume
> another reviewer-pass is necessary even for small changes like this---if not,
> apologies for the additional email!)

Still LGTM, although for future reference rebase-only changes like this don't
require another reviewer pass unless you actually made some non-trivial changes.

[commit-bot: I haz the power, 2013-05-06 23:13:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/heuristicist@gmail.com/14963003/16001

[commit-bot: I haz the power, 2013-05-07 13:05:05]

Change committed as 198704