Issue 14962011: Fix RunTests to not stall on empty test list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14962011: Fix RunTests to not stall on empty test list (Closed)

Created:
7 years, 7 months ago by Isaac (away)

Modified:
7 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, bevc

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix RunTests to not stall on empty test list Some PRESUBMIT files dynamically generate test list and so may pass an empty list to RunTests. There appears to be a bug in multiprocessing.Pool that causes a stall in map_async with an empty list. TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=200613

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	presubmit_support.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/14962011/1

7 years, 7 months ago (2013-05-16 20:02:27 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages