chrome/renderer/resources/extensions/omnibox_custom_bindings.js - Issue 14960004: Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

Issue 14960004: Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omniboxJSON

Patch Set: Modify SetOmniboxDefaultSuggestion to generate a dictionary compatible with api::omnibox::SuggestRe… Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

index 32ff65a7f6867880a8e901693ae63b5d5203d597..ee12051655b1ebbc7d37ce1bfc9cb2f9cb0b169d 100644

--- a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

@@ -90,7 +90,6 @@ binding.registerCustomHook(function(bindingsAPI) {

throw new Error(

'setDefaultSuggestion cannot contain the "content" field');

}

- suggestResult.content = '';

return [suggestResult];

});

« chrome/common/extensions/api/omnibox.json ('K') | « chrome/common/extensions/api/omnibox.json ('k') | no next file » | no next file with comments »