Issue 14960004: Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult

Issue 14960004: Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult (Closed)

Created:
7 years, 7 months ago by Aaron Jacobs

Modified:
7 years, 7 months ago

Reviewers:
Devlin, not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@omniboxJSON

Visibility:
Public.

More Reviews

Description

Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult Adds new DefaultSuggestResult type to the omnibox json schema BUG=237817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199135

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : Modify SetOmniboxDefaultSuggestion to generate a dictionary compatible with api::omnibox::SuggestRe… #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -13 lines)			Patch
M	chrome/browser/extensions/api/omnibox/omnibox_api.cc	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/omnibox/omnibox_unittest.cc	View	1	2 chunks	+40 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/omnibox.json	View		4 chunks	+51 lines, -7 lines	1 comment	Download
M	chrome/renderer/resources/extensions/omnibox_custom_bindings.js	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Aaron Jacobs

On 2013/05/07 00:04:02, Aaron Jacobs wrote: GetOmniboxDefaultSuggestion still needs to be updated to handle the ...

7 years, 7 months ago (2013-05-07 00:07:22 UTC) #2

Aaron Jacobs

kalman: This should fix the referenced bug, let me know what you think.

7 years, 7 months ago (2013-05-08 22:02:03 UTC) #3

not at google - send to devlin

lgtm https://codereview.chromium.org/14960004/diff/7001/chrome/common/extensions/api/omnibox.json File chrome/common/extensions/api/omnibox.json (right): https://codereview.chromium.org/14960004/diff/7001/chrome/common/extensions/api/omnibox.json#newcode61 chrome/common/extensions/api/omnibox.json:61: "description": "A suggest result.", it'd be nice to ...

7 years, 7 months ago (2013-05-08 22:19:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/14960004/7001

7 years, 7 months ago (2013-05-08 22:34:51 UTC) #5

Message was sent while issue was closed.

Change committed as 199135

Expand Messages | Collapse Messages