Issue 14957002: [Resumption 7/11] Add a CanResume() method to DownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14957002: [Resumption 7/11] Add a CanResume() method to DownloadItem. (Closed)

Created:
7 years, 7 months ago by asanka

Modified:
7 years, 7 months ago

Reviewers:
Randy Smith (Not in Mondays), Jói

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, jam, joi+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Downloads] Add a CanResume() method to DownloadItem. The method indicates whether a download can be resumed. I.e. Calling DownloadItem::Resume() is expected to do something. It will be used by the UI when support for downloads resumption is added. BUG=7648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200719

Patch Set 1 : #

Patch Set 2 : Merge with r200532 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -3 lines)			Patch
M	content/browser/download/download_item_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/download/download_item_impl.cc	View	1	3 chunks	+24 lines, -3 lines	0 comments	Download
M	content/public/browser/download_item.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/public/test/mock_download_item.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

asanka

On 2013/05/15 15:26:59, rdsmith wrote: > lgtm Thanks! joi: Could you take a look at ...

7 years, 7 months ago (2013-05-16 15:09:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/14957002/6001

7 years, 7 months ago (2013-05-16 21:57:05 UTC) #5

Message was sent while issue was closed.

Change committed as 200719

Expand Messages | Collapse Messages