chrome/browser/extensions/external_registry_loader_win.h - Issue 1495403002: Observe adding external extensions via windows registry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_loader_win.h

Issue 1495403002: Observe adding external extensions via windows registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move prefs to OnUpdated's param, instead of storing, to avoid multi-thread issues Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/external_loader.h ('K') | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/external_registry_loader_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_registry_loader_win.h

diff --git a/chrome/browser/extensions/external_registry_loader_win.h b/chrome/browser/extensions/external_registry_loader_win.h

index 25de48dfb92a9ceba1c2581c8d256e08f203cb88..fca0c5701f6474581af3f0251aa8686f44b116c4 100644

--- a/chrome/browser/extensions/external_registry_loader_win.h

+++ b/chrome/browser/extensions/external_registry_loader_win.h

@@ -7,6 +7,7 @@

#include "base/compiler_specific.h"

#include "base/macros.h"

+#include "base/win/registry.h"

#include "chrome/browser/extensions/external_loader.h"

namespace extensions {

@@ -23,7 +24,14 @@ class ExternalRegistryLoader : public ExternalLoader {

~ExternalRegistryLoader() override {}

+ scoped_ptr<base::DictionaryValue> LoadPrefsOnFileThread();

void LoadOnFileThread();

+ void CompleteLoadAndStartWatchingRegistry();

+ void UpdatePrefsOnFileThread();

+ void OnRegistryKeyChanged(base::win::RegKey* key);

+ base::win::RegKey hklm_key_;

+ base::win::RegKey hkcu_key_;

DISALLOW_COPY_AND_ASSIGN(ExternalRegistryLoader);

};