Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: extensions/browser/external_provider_interface.h

Issue 1495403002: Observe adding external extensions via windows registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing files Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/external_provider_interface.h
diff --git a/extensions/browser/external_provider_interface.h b/extensions/browser/external_provider_interface.h
index 801f4ede5640de99259898da3c2b0e22cbb9e336..09d9950966ddc39cfca6e33fa16dbf11ebfc9dea 100644
--- a/extensions/browser/external_provider_interface.h
+++ b/extensions/browser/external_provider_interface.h
@@ -8,12 +8,12 @@
#include <vector>
#include "base/memory/linked_ptr.h"
+#include "extensions/browser/external_extension_install_info.h"
#include "extensions/common/manifest.h"
class GURL;
namespace base {
-class FilePath;
class Version;
}
@@ -35,24 +35,14 @@ class ExternalProviderInterface {
// proceed if the extension is already installed from a higher priority
// location.
virtual bool OnExternalExtensionFileFound(
- const std::string& id,
- const base::Version* version,
- const base::FilePath& path,
- Manifest::Location location,
- int creation_flags,
- bool mark_acknowledged,
- bool install_immediately) = 0;
+ ExternalExtensionInstallInfoFile* info) = 0;
asargent_no_longer_on_chrome 2016/01/25 18:50:52 nit: If ownership of this data is passed, this sho
lazyboy 2016/01/26 05:20:05 Done.
// Return true if the extension install will proceed. Install might not
// proceed if the extension is already installed from a higher priority
// location.
virtual bool OnExternalExtensionUpdateUrlFound(
- const std::string& id,
- const std::string& install_parameter,
- const GURL& update_url,
- Manifest::Location location,
- int creation_flags,
- bool mark_acknowledged) = 0;
+ ExternalExtensionInstallInfoUpdateUrl* info,
asargent_no_longer_on_chrome 2016/01/25 18:50:52 same comment re: ownership
lazyboy 2016/01/26 05:20:05 Done.
+ bool is_initial_load) = 0;
// Called after all the external extensions have been reported
// through the above two methods. |provider| is a pointer to the
@@ -62,6 +52,18 @@ class ExternalProviderInterface {
virtual void OnExternalProviderReady(
const ExternalProviderInterface* provider) = 0;
+ // Once this provider becomes "ready", it can send additional external
+ // extensions it learns about later on through
+ // OnExternalExtensionUpdateUrlFound() or OnExternalExtensionFileFound().
+ // This method will be called each time the provider finds a set of
+ // updated external extensions.
+ virtual void OnExternalProviderUpdateComplete(
+ const ExternalProviderInterface* provider,
+ const ScopedVector<ExternalExtensionInstallInfoUpdateUrl>&
+ update_url_extensions,
+ const ScopedVector<ExternalExtensionInstallInfoFile>& file_extensions,
+ const std::set<std::string>& removed_extensions) = 0;
+
protected:
virtual ~VisitorInterface() {}
};

Powered by Google App Engine
This is Rietveld 408576698