Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 1495403002: Observe adding external extensions via windows registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: guard updater_->CheckNow() call, rework Provider->ExtensionService interaction Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 01fea8ec5a874d8dd5078d7d1009d18ce2fd092e..2e3fac7bce79afac890ec54df339827d5d30dfdd 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -228,24 +228,24 @@ class ExtensionService
bool is_ready() override;
base::SequencedTaskRunner* GetFileTaskRunner() override;
- // ExternalProvider::Visitor implementation.
+ // ExternalProvider::VisitorInterface implementation.
// Exposed for testing.
- bool OnExternalExtensionFileFound(const std::string& id,
- const base::Version* version,
- const base::FilePath& path,
- extensions::Manifest::Location location,
- int creation_flags,
- bool mark_acknowledged,
- bool install_immediately) override;
+ bool OnExternalExtensionFileFound(
+ extensions::ExternalProviderInterface::FileExtensionInfo* info) override;
bool OnExternalExtensionUpdateUrlFound(
- const std::string& id,
- const std::string& install_parameter,
- const GURL& update_url,
- extensions::Manifest::Location location,
- int creation_flags,
- bool mark_acknowledged) override;
+ extensions::ExternalProviderInterface::UpdateUrlExtensionInfo* info,
+ bool is_initial_load) override;
void OnExternalProviderReady(
const extensions::ExternalProviderInterface* provider) override;
+ void OnExternalProviderUpdateComplete(
lazyboy 2016/01/22 07:52:41 This function now includes all the info the provid
asargent_no_longer_on_chrome 2016/01/25 18:50:52 Acknowledged.
+ const extensions::ExternalProviderInterface* provider,
+ const ScopedVector<
+ extensions::ExternalProviderInterface::UpdateUrlExtensionInfo>&
+ external_update_url_extensions,
+ const ScopedVector<
+ extensions::ExternalProviderInterface::FileExtensionInfo>&
+ external_file_extensions,
+ const std::set<std::string>& removed_extensions) override;
// ExtensionManagement::Observer implementation:
void OnExtensionManagementSettingsChanged() override;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698