Issue 14949016: Fix tools/licenses.py to better prune directories that are empty except for VCS metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14949016: Fix tools/licenses.py to better prune directories that are empty except for VCS metadata. (Closed)

Created:
7 years, 7 months ago by Lei Zhang

Modified:
7 years, 7 months ago

Reviewers:
Steve Block, Nico

CC:
chromium-reviews, Nico, phajdan_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix tools/licenses.py to better prune directories that are empty except for VCS metadata. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200102

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	tools/licenses.py	View		2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I can't CQ the removal of third_party/bzip2, because it's an empty directory, but the license ...

7 years, 7 months ago (2013-05-14 00:25:24 UTC) #1

Nico

lgtm https://codereview.chromium.org/14949016/diff/1/tools/licenses.py File tools/licenses.py (right): https://codereview.chromium.org/14949016/diff/1/tools/licenses.py#newcode337 tools/licenses.py:337: dirs.remove(vcs_metadata) Huh, I didn't know this works! (I ...

7 years, 7 months ago (2013-05-14 03:06:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/14949016/1

7 years, 7 months ago (2013-05-14 18:21:08 UTC) #3

Message was sent while issue was closed.

Change committed as 200102

Expand Messages | Collapse Messages