Add myself to WATCHERS (viewport interaction, media queries)

Add myself to WATCHERS (viewport interaction, media queries)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149947

[eseidel, 2013-05-08 08:45:18]

lgtm

On Wed, May 8, 2013 at 12:07 AM,  <kenneth.r.christiansen@intel.com> wrote:
> Reviewers: ,
>
> Description:
> Add myself to WATCHERS (viewport interaction, media queries)
>
>
> Don't check for @media rules affected by viewport changes in every layout
>
> Backport from WebKit; original patch by Andreas Kling <akling@apple.com>
>
> Move the logic that checks if any @media rules are affected by a change in
> the viewport size to FrameView::setFrameRect(). This way it's no longer
> necessary to do the style recalc synchronously, which allows us to coalesce
> multiple updates in some cases.
>
> WKBUG=115370
> BUG=
>
> Please review this at https://codereview.chromium.org/14947004/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files:
>   M WATCHLISTS
>
>
> Index: WATCHLISTS
> diff --git a/WATCHLISTS b/WATCHLISTS
> index
>
3cb13abe8901b07e3cd7367e415ce66d0c567629..eada9b2e5238e534b56fef87829b28a607b4b2b1
> 100644
> --- a/WATCHLISTS
> +++ b/WATCHLISTS
> @@ -95,6 +95,11 @@
>                    '|Source/modules/(encryptedmedia|mediasource)' \
>                    '|Source/WebKit/chromium/.*Media.*' \
>      },
> +    'media_queries': {
> +        'filepath': 'Source/core/css/CSSMediaRule.*' \
> +                    '|Source/core/css/MediaList.*' \
> +                    '|Source/core/css/MediaQuery.*'
> +    },
>      'fileapi': {
>        'filepath': 'Source/modules/filesystem/' \
>                    '|Source/core/fileapi/' \
> @@ -106,6 +111,13 @@
>        'filepath': 'Source/modules/quota/' \
>                    '|Source/WebKit/chromium/.*Quota.*'
>      },
> +    'viewport_interaction': {
> +      'filepath': 'Source/core/css/.*Viewport.*' \
> +                  '|Source/core/dom/ViewportArguments.*' \
> +                  '|Source/core/html/HTMLMetaElement.*' \
> +                  '|Source/core/page/FrameView.*' \
> +                  '|Source/core/page/scrolling'
> +    },
>    },
>
>    'WATCHLISTS': {
> @@ -149,7 +161,9 @@
>      'prerender': [ 'gavinp+prerender@chromium.org' ],
>      'track': ['vcarbune@chromium.org'],
>      'media': [ 'feature-media-reviews@chromium.org' ],
> +    'media_queries': [ 'kenneth.christiansen@gmail.com' ],
>      'fileapi': [ 'kinuko@chromium.org' ],
>      'quota': [ 'kinuko@chromium.org' ],
> +    'viewport_interaction': [ 'kenneth.christiansen@gmail.com' ],
>    },
>  }
>
>

[commit-bot: I haz the power, 2013-05-08 08:52:43]

No reviewers yet.

[eseidel, 2013-05-08 08:57:53]

lgtm

[commit-bot: I haz the power, 2013-05-08 08:58:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/14947...

[commit-bot: I haz the power, 2013-05-08 09:37:36]

Change committed as 149947