Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2647)

Unified Diff: chrome/browser/ui/cocoa/first_run_dialog.mm

Issue 14946003: Record first run startup metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Startup.FirstRun.BrowserMessageLoopStartTimeFromMainEntry --> Startup.BrowserMessageLoopStartTimeFr… Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/first_run/first_run_win.cc ('k') | chrome/browser/ui/gtk/first_run_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/first_run_dialog.mm
diff --git a/chrome/browser/ui/cocoa/first_run_dialog.mm b/chrome/browser/ui/cocoa/first_run_dialog.mm
index 9168a552e386b8556c2ca772b0caa9d4584616cb..8e8514e67be290514b15bc8ef9aeed8008d7e8c5 100644
--- a/chrome/browser/ui/cocoa/first_run_dialog.mm
+++ b/chrome/browser/ui/cocoa/first_run_dialog.mm
@@ -78,7 +78,9 @@ void FirstRunShowBridge::ShowDialog() {
FirstRunShowBridge::~FirstRunShowBridge() {}
// Show the first run UI.
-void ShowFirstRun(Profile* profile) {
+// Returns true if the first run dialog was shown.
+bool ShowFirstRun(Profile* profile) {
+ bool dialog_shown = false;
#if defined(GOOGLE_CHROME_BUILD)
// The purpose of the dialog is to ask the user to enable stats and crash
// reporting. This setting may be controlled through configuration management
@@ -93,6 +95,7 @@ void ShowFirstRun(Profile* profile) {
[[FirstRunDialogController alloc] init]);
[dialog.get() showWindow:nil];
+ dialog_shown = true;
// If the dialog asked the user to opt-in for stats and crash reporting,
// record the decision and enable the crash reporter if appropriate.
@@ -129,6 +132,8 @@ void ShowFirstRun(Profile* profile) {
first_run::SetShowFirstRunBubblePref(first_run::FIRST_RUN_BUBBLE_SHOW);
}
first_run::SetShouldShowWelcomePage();
+
+ return dialog_shown;
}
// True when the stats checkbox should be checked by default. This is only
@@ -142,8 +147,8 @@ bool StatsCheckboxDefault() {
namespace first_run {
-void ShowFirstRunDialog(Profile* profile) {
- ShowFirstRun(profile);
+bool ShowFirstRunDialog(Profile* profile) {
+ return ShowFirstRun(profile);
}
} // namespace first_run
« no previous file with comments | « chrome/browser/first_run/first_run_win.cc ('k') | chrome/browser/ui/gtk/first_run_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698