Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 14944010: Make it possible to run WebGL conformance tests on Android (Closed)

Created:
7 years, 7 months ago by Sami
Modified:
7 years, 7 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, sail+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bajones, greggman
Visibility:
Public.

Description

Make it possible to run WebGL conformance tests on Android This patch implements the following changes to make it possible to run the WebGL conformance test suite on Android: 1. Copy WebGL test data files to the device. 2. When running the conformance test, turn on WebGL with the --enable-webgl command line flag. 3. Avoid validating the PCI vendor and device ids for the GPU because Android has no such concept. With these changes, you can run the WebGL conformance test by first building content_browsertests_apk, removing the WebGL exclusion from build/android/pylib/gtest/filter/content_browsertests_disabled and then executing: $ build/android/run_browser_tests.py -f WebGLConformanceTest.* BUG=138226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200298

Patch Set 1 #

Patch Set 2 : Fix win and x11 builds. #

Patch Set 3 : Actually change the right function for win. #

Patch Set 4 : Retry upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -20 lines) Patch
build/android/pylib/gtest/test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download
content/browser/gpu/webgl_conformance_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
content/gpu/gpu_info_collector.h View 1 chunk +7 lines, -1 line 0 comments Download
content/gpu/gpu_info_collector_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
content/gpu/gpu_info_collector_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
content/gpu/gpu_info_collector_win.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
content/gpu/gpu_info_collector_x11.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
content/test/gpu/gpu_test_config.h View 1 chunk +7 lines, -0 lines 0 comments Download
content/test/gpu/gpu_test_config.cc View 6 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Sami
This gets WebGL tests going on Android. PTAL.
7 years, 7 months ago (2013-05-13 15:25:37 UTC) #1
Ken Russell (switch to Gerrit)
These changes LGTM, but please ask zmo for a review too. Note that the GPU ...
7 years, 7 months ago (2013-05-13 18:20:07 UTC) #2
Zhenyao Mo
LGTM
7 years, 7 months ago (2013-05-13 21:51:17 UTC) #3
Sami
Thanks for the hint about the move to telemetry. This looks like the bug for ...
7 years, 7 months ago (2013-05-14 09:37:01 UTC) #4
bulach
lgtm for android/pylib, thanks!
7 years, 7 months ago (2013-05-14 13:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/1
7 years, 7 months ago (2013-05-14 13:29:36 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-14 13:47:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/23001
7 years, 7 months ago (2013-05-14 13:55:40 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=127524
7 years, 7 months ago (2013-05-14 14:42:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/47001
7 years, 7 months ago (2013-05-14 14:51:07 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=127563
7 years, 7 months ago (2013-05-14 15:42:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/47001
7 years, 7 months ago (2013-05-14 15:51:01 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=127583
7 years, 7 months ago (2013-05-14 16:16:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/47001
7 years, 7 months ago (2013-05-14 18:12:53 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=148437
7 years, 7 months ago (2013-05-14 21:53:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/47001
7 years, 7 months ago (2013-05-15 09:51:22 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=148980
7 years, 7 months ago (2013-05-15 14:56:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14944010/47001
7 years, 7 months ago (2013-05-15 15:22:21 UTC) #18
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 16:46:57 UTC) #19
Message was sent while issue was closed.
Change committed as 200298

Powered by Google App Engine
This is Rietveld 408576698