Add RSAPrivateKey::CreateFromKeypair()

Add RSAPrivateKey::CreateFromKeypair()

Add a static method to create an RSAPrivateKey object from an NSS public/private
keypair.  Only declared and implemented when USE_NSS is defined.

BUG=235179
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198985

[Ryan Sleevi, 2013-05-07 19:45:23]

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key.h
File crypto/rsa_private_key.h (right):

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key.h#n...
crypto/rsa_private_key.h:16: struct SECKEYPublicKeyStr;
minor nit: Would you mind updating these to be

typedef struct SECKEYPrivateKeyStr SECKEYPrivateKey;
typedef struct SECKEYPublicKeyStr SECKEYPublicKey;

(This will match our normal style for handling OpenSSL & NSS definitions )

And then updating the SECKEYPrivateKeyStr* to return SECKEYPrivateKey*, etc.

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key_nss.cc
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key_nss...
crypto/rsa_private_key_nss.cc:86: SECKEYPublicKeyStr* public_key) {
From an API perspective, there should be a little bit more error handling to
ensure it's right:

DCHECK(key);
DCHECK(public_key);

if (SECKEY_GetPrivateKeyType(public_key) != rsaKey ||
    SECKEY_GetPrivateKeyType(private_key) != rsaKey)
  return NULL;

You could also ignore |public_key| entirely and use SECKEY_ConvertToPublicKey -
which will |only| work for RSA keys (and only if the CKA_MODULUS and
CKA_PUBLIC_EXPONENT are readable - but they should be for all but the dumbest of
PKCS#11 smart cards), which will at least "guarantee" that |key| and
|public_key| are pairwise consistent - which we currently guarantee for the
other create functions.

[Chris Masone, 2013-05-07 21:00:38]

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key.h
File crypto/rsa_private_key.h (right):

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key.h#n...
crypto/rsa_private_key.h:16: struct SECKEYPublicKeyStr;
On 2013/05/07 19:45:23, Ryan Sleevi wrote:
> minor nit: Would you mind updating these to be
> 
> typedef struct SECKEYPrivateKeyStr SECKEYPrivateKey;
> typedef struct SECKEYPublicKeyStr SECKEYPublicKey;
> 
> (This will match our normal style for handling OpenSSL & NSS definitions )
> 
> And then updating the SECKEYPrivateKeyStr* to return SECKEYPrivateKey*, etc.

Done.

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key_nss.cc
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/14941007/diff/4001/crypto/rsa_private_key_nss...
crypto/rsa_private_key_nss.cc:86: SECKEYPublicKeyStr* public_key) {
On 2013/05/07 19:45:23, Ryan Sleevi wrote:
> From an API perspective, there should be a little bit more error handling to
> ensure it's right:
> 
> DCHECK(key);
> DCHECK(public_key);
> 
> if (SECKEY_GetPrivateKeyType(public_key) != rsaKey ||
>     SECKEY_GetPrivateKeyType(private_key) != rsaKey)
>   return NULL;
> 
> You could also ignore |public_key| entirely and use SECKEY_ConvertToPublicKey
-
> which will |only| work for RSA keys (and only if the CKA_MODULUS and
> CKA_PUBLIC_EXPONENT are readable - but they should be for all but the dumbest
of
> PKCS#11 smart cards), which will at least "guarantee" that |key| and
> |public_key| are pairwise consistent - which we currently guarantee for the
> other create functions.

Done.

[Ryan Sleevi, 2013-05-07 21:07:50]

LGTM with nit

https://codereview.chromium.org/14941007/diff/18001/crypto/rsa_private_key_ns...
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/14941007/diff/18001/crypto/rsa_private_key_ns...
crypto/rsa_private_key_nss.cc:91: return copy;
if (!copy->key_ || !copy->public_key_) {
  NOTREACHED();
  delete copy;
  return NULL;
}
return copy;

[This because RSAPrivateKey *may* be constructed from user inputs]

[Chris Masone, 2013-05-07 21:16:38]

https://codereview.chromium.org/14941007/diff/18001/crypto/rsa_private_key_ns...
File crypto/rsa_private_key_nss.cc (right):

https://codereview.chromium.org/14941007/diff/18001/crypto/rsa_private_key_ns...
crypto/rsa_private_key_nss.cc:91: return copy;
On 2013/05/07 21:07:50, Ryan Sleevi wrote:
> if (!copy->key_ || !copy->public_key_) {
>   NOTREACHED();
>   delete copy;
>   return NULL;
> }
> return copy;
> 
> [This because RSAPrivateKey *may* be constructed from user inputs]

Done.

[commit-bot: I haz the power, 2013-05-07 21:17:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cmasone@chromium.org/14941007/24001

[commit-bot: I haz the power, 2013-05-07 22:17:41]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-07 23:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cmasone@chromium.org/14941007/24001

[commit-bot: I haz the power, 2013-05-08 20:35:25]

Change committed as 198985