Teach landmines script that Linux now uses ninja by default.

build/landmines.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This file holds a list of reasons why a particular build needs to be clobbered
 (or a list of 'landmines').
 
 This script runs every build as a hook. If it detects that the build should
@@ skipping 29 matching lines @@
         val.append(ret if ret is not None else default)
         if logging.getLogger().isEnabledFor(logging.INFO):
           print '%s -> %r' % (func.__name__, val[0])
       return val[0]
     return inner
   return memoizer
 
 
 @memoize()
 def IsWindows():
-  return sys.platform.startswith('win') or sys.platform == 'cygwin'
+  return sys.platform in ['win32', 'cygwin']
 
 
 @memoize()
 def IsLinux():
   return sys.platform.startswith('linux')
 
 
 @memoize()
 def IsMac():
-  return sys.platform.startswith('darwin')
+  return sys.platform == 'darwin'
 
 
 @memoize()
 def gyp_defines():
   """Parses and returns GYP_DEFINES env var as a dictionary."""
   return dict(arg.split('=', 1)
       for arg in shlex.split(os.environ.get('GYP_DEFINES', '')))
 
 
 @memoize()
@@ skipping 45 matching lines @@
       return generator
   else:
     if platform() == 'android':
       # Good enough for now? Do any android bots use make?
       return 'ninja'
     elif platform() == 'ios':
       return 'xcode'
     elif IsWindows():
       return 'msvs'
     elif IsLinux():
-      return 'make'
+      return 'ninja'
     elif IsMac():
       return 'xcode'
     else:
       assert False, 'Don\'t know what builder we\'re using!'
 
 
 def get_landmines(target):
   """
   ALL LANDMINES ARE DEFINED HERE.
   target is 'Release' or 'Debug'
@@ skipping 23 matching lines @@
     r'c:\b\build\slave\win\build\src\out\Release'
     '/mnt/data/b/build/slave/linux/build/src/out/Debug'
     '/b/build/slave/ios_rel_device/build/src/xcodebuild/Release-iphoneos'
 
   Keep this function in sync with tools/build/scripts/slave/compile.py
   """
   ret = None
   if build_tool == 'xcode':
     ret = os.path.join(SRC_DIR, 'xcodebuild',
         target + ('-iphoneos' if is_iphone else ''))
-  elif build_tool == 'make':
-    ret = os.path.join(SRC_DIR, 'out', target)
-  elif build_tool in ['ninja', 'ninja-ios']:
+  elif build_tool in ['make', 'ninja', 'ninja-ios']:  # TODO: Remove ninja-ios.
     ret = os.path.join(SRC_DIR, 'out', target)
   elif build_tool in ['msvs', 'vs', 'ib']:
     ret = os.path.join(SRC_DIR, 'build', target)
   elif build_tool == 'scons':
     ret = os.path.join(SRC_DIR, 'sconsbuild', target)
   else:
     raise NotImplementedError('Unexpected GYP_GENERATORS (%s)' % build_tool)
   return os.path.abspath(ret)
 
 
@@ skipping 45 matching lines @@
   gyp_helper.apply_chromium_gyp_env()
 
   for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'):
     set_up_landmines(target)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())