Rename the "Experimental WebKit Features" flag.

Rename the "Experimental WebKit Features" flag.

Since we're not WebKit-based any more, this flag is confusingly named.
"Web Platform" more accurately reflects the flag's intent.

BUG=238153
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210820

[Mike West, 2013-05-07 04:27:24]

Hey Max, would you mind confirming the wording of the "Experimental Web Platform
Features" flag before I go looking for OWNERS to review the patch?

Thanks!

-mike

[ojan, 2013-05-07 05:53:05]

lgtm

[ojan, 2013-05-07 05:53:28]

lol, whoops. I'm not OWNER on any of these directories. :)

[Mike West, 2013-05-07 06:06:30]

On 2013/05/07 05:53:28, ojan wrote:
> lol, whoops. I'm not OWNER on any of these directories. :)

Not true! chrome/browser/about_flags.cc and chrome/app/generated_resources.grd
have a * per_file OWNER list. Your support is valuable! :)

creis: Would you mind rubber-stamping the content/ updates?
jochen: Could you do the same for chrome/?

Thanks!

[jochen (gone - plz use gerrit), 2013-05-07 09:41:13]

https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
File content/public/common/content_switches.cc (right):

https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
content/public/common/content_switches.cc:307:
"enable-experimental-web-platform-features";
you will probably want keep the old switch around for a while, and add some
migration code.

[Mike West, 2013-05-07 12:03:25]

On 2013/05/07 09:41:13, jochen wrote:
>
https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
> File content/public/common/content_switches.cc (right):
> 
>
https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
> content/public/common/content_switches.cc:307:
> "enable-experimental-web-platform-features";
> you will probably want keep the old switch around for a while, and add some
> migration code.

Possibly a good idea. I figured that this was an experimental-enough thing that
having it toggle off out from under someone's feet wouldn't be shocking, but
that might have been a bad idea.

What would a migration look like? Are there any in the code right now I could
blindly cargo-cult? :)

[jochen (gone - plz use gerrit), 2013-05-07 14:59:57]

On 2013/05/07 12:03:25, Mike West (chromium) wrote:
> On 2013/05/07 09:41:13, jochen wrote:
> >
>
https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
> > File content/public/common/content_switches.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/14940009/diff/23001/content/public/com...
> > content/public/common/content_switches.cc:307:
> > "enable-experimental-web-platform-features";
> > you will probably want keep the old switch around for a while, and add some
> > migration code.
> 
> Possibly a good idea. I figured that this was an experimental-enough thing
that
> having it toggle off out from under someone's feet wouldn't be shocking, but
> that might have been a bad idea.
> 
> What would a migration look like? Are there any in the code right now I could
> blindly cargo-cult? :)

hum, dunno. I'd probably search for calls to CommandLine::AppendASCII

OTOH, maybe we just rename the switch.. after all, it's about:flags

[Max Heinritz, 2013-05-07 15:16:56]

>Hey Max, would you mind confirming the wording of the "Experimental Web
Platform
>Features" flag before I go looking for OWNERS to review the patch?

Confirmed! Per http://www.chromium.org/blink#vendor-prefixes

Thanks for double-checking.

[Charlie Reis, 2013-05-07 16:49:43]

content LGTM, once you decide whether you want to support the old flag as well. 
(I'm fine either way, since it's experimental in the first place.)

[ojan, 2013-05-07 17:40:34]

+1 to not worrying about migrating the old flag.

[jochen (gone - plz use gerrit), 2013-05-07 18:10:37]

chrome/ lgtm

[commit-bot: I haz the power, 2013-05-08 14:23:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/14940009/23001

[commit-bot: I haz the power, 2013-05-08 21:51:18]

Failed to apply patch for content/shell/shell_main_delegate.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: content/shell/shell_main_delegate.cc
  |diff --git a/content/shell/shell_main_delegate.cc
b/content/shell/shell_main_delegate.cc
  |index
69813218a7888be0379b3609aac345568b3897cb..ce6a1b5ec68dadf83bdb36476058c2e399e096c3
100644
  |--- a/content/shell/shell_main_delegate.cc
  |+++ b/content/shell/shell_main_delegate.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       content/shell/shell_main_delegate.cc
Index: content/shell/shell_main_delegate.cc
diff --git a/content/shell/shell_main_delegate.cc
b/content/shell/shell_main_delegate.cc
index
69813218a7888be0379b3609aac345568b3897cb..ce6a1b5ec68dadf83bdb36476058c2e399e096c3
100644
--- a/content/shell/shell_main_delegate.cc
+++ b/content/shell/shell_main_delegate.cc
@@ -111,7 +111,7 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code)
{
     SetAllowOSMesaImageTransportForTesting();
     DisableSystemDragDrop();
     command_line.AppendSwitch(switches::kSkipGpuDataLoading);
-    command_line.AppendSwitch(switches::kEnableExperimentalWebKitFeatures);
+   
command_line.AppendSwitch(switches::kEnableExperimentalWebPlatformFeatures);
     command_line.AppendSwitch(switches::kEnableCssShaders);
     command_line.AppendSwitchASCII(switches::kTouchEvents,
                                    switches::kTouchEventsEnabled);

[commit-bot: I haz the power, 2013-05-13 06:44:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/14940009/23001

[commit-bot: I haz the power, 2013-05-13 06:44:37]

Failed to apply patch for content/browser/web_contents/web_contents_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/web_contents/web_contents_impl.cc
  Hunk #1 FAILED at 504.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/web_contents/web_contents_impl.cc.rej

Patch:       content/browser/web_contents/web_contents_impl.cc
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc
b/content/browser/web_contents/web_contents_impl.cc
index
43ec8e581e47467e292228b338ab5123f4179980..02042bf9b4f7023b8fdedbefbeb431470e3c471a
100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -504,15 +504,15 @@ WebPreferences
WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh,
   prefs.fullscreen_enabled =
       !command_line.HasSwitch(switches::kDisableFullScreen);
   prefs.css_sticky_position_enabled =
-      command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures);
+      command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
   prefs.css_shaders_enabled =
       command_line.HasSwitch(switches::kEnableCssShaders);
   prefs.css_variables_enabled =
-      command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures);
+      command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
   prefs.css_grid_layout_enabled =
-      command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures);
+      command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
   prefs.lazy_layout_enabled =
-      command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures);
+      command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
 
   // TODO(abarth, eseidel): Enable threaded_html_parser by default on Android
   // once crbug 230542 is resolved.

[commit-bot: I haz the power, 2013-07-10 07:15:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/14940009/51001

[commit-bot: I haz the power, 2013-07-10 13:01:24]

Change committed as 210820

[pauljensen, 2013-07-10 14:10:41]

I think you meant to reference bug 238152