Remove unused code behind USE(PLATFORM_TEXT_TRACK_MENU)

Remove unused code behind USE(PLATFORM_TEXT_TRACK_MENU)

This code seems to have been added for the WebKit Apple port but
is not used in Blink.

R=vcarbune@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150284

[vcarbune.chromium, 2013-05-03 23:25:19]

LGTM and thanks for removing it

CCing Silvia, FYI or just in case you have any thoughts about this

[commit-bot: I haz the power, 2013-05-03 23:30:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/14936003/1

[commit-bot: I haz the power, 2013-05-04 03:11:44]

Retried try job too often on blink_bare_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare...

[nessy, 2013-05-04 13:38:49]

We need to include much of this code in our codebase, too. I have patches
prepared from before the split, but haven't got around to adapting them yet. I
guess it's ok for now to remove this...

[adamk, 2013-05-05 17:16:44]

On 2013/05/04 13:38:49, nessy wrote:
> We need to include much of this code in our codebase, too. I have patches
> prepared from before the split, but haven't got around to adapting them yet. I
> guess it's ok for now to remove this...

Is there some minimal amount of code we need to just start compiling it (by
removing the guards)? My main intent was to delete dead code (since it'll easily
break if it doesn't get exercised).

[adamk, 2013-05-09 18:08:21]

Silvia, is it ok if if I just remove this for now? You can resurrect along with
your text track changes when you get a chance to work on those, but I'd rather
not leave dead code in the tree (it's likely to go stale anyway).

[adamk, 2013-05-14 01:28:10]

+ojan for core owners. I plan to land this now; if it needs to be resurrected
this patch can easily be reverted.

[ojan, 2013-05-14 01:37:43]

lgtm

[commit-bot: I haz the power, 2013-05-14 01:44:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/14936003/15001

[commit-bot: I haz the power, 2013-05-14 01:44:55]

Failed to apply patch for Source/core/platform/graphics/MediaPlayer.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/platform/graphics/MediaPlayer.h
  Hunk #1 FAILED at 38.
  Hunk #2 succeeded at 357 (offset -41 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/platform/graphics/MediaPlayer.h.rej

Patch:       Source/core/platform/graphics/MediaPlayer.h
Index: Source/core/platform/graphics/MediaPlayer.h
diff --git a/Source/core/platform/graphics/MediaPlayer.h
b/Source/core/platform/graphics/MediaPlayer.h
index
10abf58abd113a9576da8989e6768e9990d93322..4bf8832bf121fae1ff4a008852f7683b479313bc
100644
--- a/Source/core/platform/graphics/MediaPlayer.h
+++ b/Source/core/platform/graphics/MediaPlayer.h
@@ -38,11 +38,6 @@
 #include <wtf/PassOwnPtr.h>
 #include <wtf/text/StringHash.h>
 
-
-#if USE(PLATFORM_TEXT_TRACK_MENU)
-#include "core/platform/graphics/PlatformTextTrackMenu.h"
-#endif
-
 OBJC_CLASS AVPlayer;
 OBJC_CLASS QTMovie;
 
@@ -398,11 +393,6 @@ public:
     bool requiresTextTrackRepresentation() const;
     void setTextTrackRepresentation(TextTrackRepresentation*);
 
-#if USE(PLATFORM_TEXT_TRACK_MENU)
-    bool implementsTextTrackControls() const;
-    PassRefPtr<PlatformTextTrackMenuInterface> textTrackMenu();
-#endif
-
 private:
     MediaPlayer(MediaPlayerClient*);
     void loadWithMediaEngine();

[commit-bot: I haz the power, 2013-05-14 01:48:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/14936003/20001

[commit-bot: I haz the power, 2013-05-14 03:08:04]

Change committed as 150284