Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: net/base/mime_util_unittest.cc

Issue 14934008: Adding unit test for two new functions in mime_util.h/cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index 565f9deeec7e44c2bf540343a7b2955866830065..079953be1c448db6d94a27acb65858cf1284777e 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -296,4 +296,29 @@ TEST(MimeUtilTest, TestGetCertificateMimeTypeForMimeType) {
GetCertificateMimeTypeForMimeType("text/plain"));
}
+TEST(MimeUtilTest, TestAddMultipartValueForUpload) {
+ const char* ref_output = "--boundary\r\nContent-Disposition: form-data;"
+ " name=\"value name\"\r\nContent-Type: content type"
+ "\r\n\r\nvalue\r\n";
+ std::string post_data;
+ AddMultipartValueForUpload("value name", "value", "boundary",
+ "content type", &post_data);
+ EXPECT_STREQ(ref_output, post_data.c_str());
+
+ const char* ref_output_no_content_type =
+ "--boundary\r\nContent-Disposition: form-data;"
+ " name=\"value name\"\r\n\r\nvalue\r\n";
+ post_data.clear();
wtc 2013/05/16 18:24:22 Nit: it would be better to test two AddMultipartVa
Henrik Grunell 2013/05/17 07:49:12 Done.
+ AddMultipartValueForUpload("value name", "value", "boundary",
+ "", &post_data);
+ EXPECT_STREQ(ref_output_no_content_type, post_data.c_str());
+}
+
+TEST(MimeUtilTest, TestAddMultipartFinalDelimiterForUpload) {
+ const char* ref_output = "--boundary--\r\n";
+ std::string post_data;
+ AddMultipartFinalDelimiterForUpload("boundary", &post_data);
+ EXPECT_STREQ(ref_output, post_data.c_str());
+}
+
} // namespace net
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698