Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: media/base/android/media_source_player.cc

Issue 14932020: Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressing comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_source_player.cc
diff --git a/media/base/android/media_source_player.cc b/media/base/android/media_source_player.cc
index b29d182d84938638a33561467efe1f6dae3f4c9a..6b740106d98d52247cbc04ebef8a71e1fa94d694 100644
--- a/media/base/android/media_source_player.cc
+++ b/media/base/android/media_source_player.cc
@@ -167,7 +167,7 @@ VideoDecoderJob::VideoDecoderJob(
const scoped_refptr<base::MessageLoopProxy>& message_loop,
const VideoCodec video_codec, const gfx::Size& size, jobject surface)
: MediaDecoderJob(false, message_loop) {
- scoped_ptr<VideoCodecBridge> codec(new VideoCodecBridge(video_codec));
+ scoped_ptr<VideoCodecBridge> codec(VideoCodecBridge::Create(video_codec));
codec->Start(video_codec, size, surface);
media_codec_bridge_.reset(codec.release());
thread_.reset(new base::Thread("MediaSource_VideoDecoderThread"));
@@ -181,7 +181,7 @@ AudioDecoderJob::AudioDecoderJob(
const uint8* extra_data,
size_t extra_data_size)
: MediaDecoderJob(true, message_loop) {
- scoped_ptr<AudioCodecBridge> codec(new AudioCodecBridge(audio_codec));
+ scoped_ptr<AudioCodecBridge> codec(AudioCodecBridge::Create(audio_codec));
codec->Start(audio_codec, sample_rate, channel_count, extra_data,
extra_data_size, true);
media_codec_bridge_.reset(codec.release());

Powered by Google App Engine
This is Rietveld 408576698