Add support for latency measurement to Telemetry smoothness benchmarks.

Add support for latency measurement to Telemetry smoothness benchmarks.

A new BrowserRenderingStats containing the latency info will be sent to the renderer so it can be retrieved from javascript.

BUG=155367
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203920

[jbauman, 2013-05-29 23:37:32]

Ok, this has been modified to deal with the cc::LatencyInfo -> ui::LatencyInfo
change.

[nduca, 2013-06-01 00:17:48]

this looks really nice. lgtm with a nit.

https://codereview.chromium.org/14931012/diff/10001/content/common/view_messa...
File content/common/view_messages.h (right):

https://codereview.chromium.org/14931012/diff/10001/content/common/view_messa...
content/common/view_messages.h:298: 
Shoudl we send stats across as base::Value? Certainly seems like that'd be a
clean way to go because it'd avoid having getting an IPC audit each time...
shrug.

[jbauman, 2013-06-01 01:30:22]

On 2013/06/01 00:17:48, nduca wrote:
> this looks really nice. lgtm with a nit.
> 
>
https://codereview.chromium.org/14931012/diff/10001/content/common/view_messa...
> File content/common/view_messages.h (right):
> 
>
https://codereview.chromium.org/14931012/diff/10001/content/common/view_messa...
> content/common/view_messages.h:298: 
> Shoudl we send stats across as base::Value? Certainly seems like that'd be a
> clean way to go because it'd avoid having getting an IPC audit each time...
> shrug.

Doing it this way seems more straightforward, and I'm hoping we won't have to
modify this very often, so I'd prefer to keep it the way it is.

[jbauman, 2013-06-01 01:47:04]

Also adding piman@ for a content/ OWNERS review.

[piman, 2013-06-01 06:44:51]

LGTM.
I don't think we should go out of our way to sidestep security reviews... Since
it's browser->renderer it shouldn't generally a problem.

[jbauman, 2013-06-03 22:43:49]

Ok, adding jln@ to review the content/common/view_messages.h change.

[jln (very slow on Chromium), 2013-06-03 23:40:14]

content/common/view_messages.h lgtm

Feel free to ignore drive-by comments.

https://codereview.chromium.org/14931012/diff/22001/content/common/browser_re...
File content/common/browser_rendering_stats.h (right):

https://codereview.chromium.org/14931012/diff/22001/content/common/browser_re...
content/common/browser_rendering_stats.h:18: uint32 input_event_count;
Should this be an int ? You're using RenderingStats::AddInt() on it.

https://codereview.chromium.org/14931012/diff/22001/content/common/view_messa...
File content/common/view_messages.h (right):

https://codereview.chromium.org/14931012/diff/22001/content/common/view_messa...
content/common/view_messages.h:917:
IPC_MESSAGE_ROUTED1(ViewMsg_SetBrowserRenderingStats,
Nit: add comment here ?

https://codereview.chromium.org/14931012/diff/22001/content/renderer/render_w...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/14931012/diff/22001/content/renderer/render_w...
content/renderer/render_widget.h:715: BrowserRenderingStats
browser_rendering_stats_;
Nit: comment?

[jln (very slow on Chromium), 2013-06-03 23:44:17]

>
https://codereview.chromium.org/14931012/diff/22001/content/common/browser_re...
> content/common/browser_rendering_stats.h:18: uint32 input_event_count;
> Should this be an int ? You're using RenderingStats::AddInt() on it.

This should have been "Should this be signed". (i.e. int32 vs uint32).

[commit-bot: I haz the power, 2013-06-03 23:57:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/14931012/34001

[commit-bot: I haz the power, 2013-06-04 11:00:06]

Change committed as 203920