Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 14931009: Make Comment constructable (Closed)

Created:
7 years, 7 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Make Comment constructable http://dom.spec.whatwg.org/#comment This allows us to do `new Comment('abc')` instead of `document.createComment('abc')`. BUG=238233 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149821

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
A LayoutTests/fast/dom/Comment/comment-constructor.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Comment/comment-constructor-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 1 2 chunks +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/Comment.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Comment.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Comment.idl View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
7 years, 7 months ago (2013-05-06 20:59:32 UTC) #1
eseidel
lgtm
7 years, 7 months ago (2013-05-06 21:02:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14931009/1
7 years, 7 months ago (2013-05-06 21:02:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/dom-constructors.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-06 21:02:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14931009/6001
7 years, 7 months ago (2013-05-06 22:33:39 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 23:20:47 UTC) #6
Message was sent while issue was closed.
Change committed as 149821

Powered by Google App Engine
This is Rietveld 408576698