Issue 14931006: Disabled select element should not fire onchange event. When dragging a disabled select element it …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14931006: Disabled select element should not fire onchange event. When dragging a disabled select element it … (Closed)

Created:
7 years, 7 months ago by yael.aharon

Modified:
7 years, 7 months ago

Reviewers:
yael.aharon1, abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Disabled select element should not fire onchange event. When dragging a disabled select element it would fire an onchange event, because there was no cached selected item. Added a check before firing the event to prevent it if the element is disabled. BUG=215494 TEST=fast/forms/select/listbox-disabled-scroll-no-onchange.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149781

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -2 lines)			Patch
A	LayoutTests/fast/forms/select/listbox-disabled-scroll-no-onchange.html	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14931006/1

7 years, 7 months ago (2013-05-06 19:10:43 UTC) #3

Message was sent while issue was closed.

Change committed as 149781

Expand Messages | Collapse Messages