Ctrl+Shift+Right in Windows should select the spacing after the word

Ctrl+Shift+Right in Windows should select the spacing after the word

Add WebCore::FrameSelection::nextWordPositionForPlatform() which takes
into consideration platform-specific editing behavior to decide
whether to skip the spacing after a word.

Use this in methods used to extend selection.

This changes the outcome of selection when editingBehavior
is set to 'win'. Therefore, many tests neeed new expectations for
chromium-win, and others have been updated.

The original patch was reviewed by Ryosuke Niwa in WebKit:

http://trac.webkit.org/changeset/148987

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150444

[csaavedra, 2013-05-06 16:50:42]

Hi Eric,

git cl upload suggested you as reviewer for this one. The original patch was
reviewed in WebKit by rniwa and was landed, as the commit message indicates.

Thank you!

Claudio

[eseidel, 2013-05-06 18:42:16]

lgtm

[commit-bot: I haz the power, 2013-05-06 18:42:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/1

[commit-bot: I haz the power, 2013-05-06 19:32:22]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[csaavedra, 2013-05-07 13:19:49]

Uploaded a new patchset, now marking unbold-in-bold.html as missing expectations
(as I can't generate a expectations image file for Windows) and having filed bug
https://code.google.com/p/chromium/issues/detail?id=238633 about this. Can
someone lgtm this again?

[eseidel, 2013-05-10 08:46:05]

lgtm

[commit-bot: I haz the power, 2013-05-10 08:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/14001

[commit-bot: I haz the power, 2013-05-10 08:46:43]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 212.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
0ee77bdc7031634e4cda6757dae7f6a8f510abe8..38bb65d5b1f529649df3f5addf57ffe15f7f0c7e
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -212,6 +212,9 @@ crbug.com/233066
http/tests/security/MessagePort/event-listener-context.html [ S
 crbug.com/233066 canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure
ImageOnlyFailure Pass Crash Timeout Missing ]
 crbug.com/233066
virtual/gpu/canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure
ImageOnlyFailure Pass Crash Timeout Missing ]
 
+# This test is missing image expectations.
+crbug.com/238633 editing/style/unbold-in-bold.html [ Missing ]
+
 # INPUT_TYPE_DATETIME_INCOMPLETE is disabled across Chromium until a better
Android UI is worked out.  See crbug.com/164561.
 webkit.org/b/109272 fast/forms/datetime [ Skip ]
 webkit.org/b/109272 fast/forms/datetime-multiple-fields [ Skip ]

[claudio.saavedra, 2013-05-10 08:54:27]

I fixed this, sorry about it. Now it will apply cleanly, lgtm please?

On 2013/05/10 08:46:43, I haz the power (commit-bot) wrote:
> Failed to apply patch for LayoutTests/TestExpectations:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file LayoutTests/TestExpectations
>   Hunk #1 FAILED at 212.
>   1 out of 1 hunk FAILED -- saving rejects to file
> LayoutTests/TestExpectations.rej
> 
> Patch:       LayoutTests/TestExpectations
> Index: LayoutTests/TestExpectations
> diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
> index
>
0ee77bdc7031634e4cda6757dae7f6a8f510abe8..38bb65d5b1f529649df3f5addf57ffe15f7f0c7e
> 100644
> --- a/LayoutTests/TestExpectations
> +++ b/LayoutTests/TestExpectations
> @@ -212,6 +212,9 @@ crbug.com/233066
> http/tests/security/MessagePort/event-listener-context.html [ S
>  crbug.com/233066 canvas/philip/tests/2d.drawImage.outsidesource.html [
Failure
> ImageOnlyFailure Pass Crash Timeout Missing ]
>  crbug.com/233066
> virtual/gpu/canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure
> ImageOnlyFailure Pass Crash Timeout Missing ]
>  
> +# This test is missing image expectations.
> +crbug.com/238633 editing/style/unbold-in-bold.html [ Missing ]
> +
>  # INPUT_TYPE_DATETIME_INCOMPLETE is disabled across Chromium until a better
> Android UI is worked out.  See crbug.com/164561.
>  webkit.org/b/109272 fast/forms/datetime [ Skip ]
>  webkit.org/b/109272 fast/forms/datetime-multiple-fields [ Skip ]

[commit-bot: I haz the power, 2013-05-10 16:48:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/20001

[commit-bot: I haz the power, 2013-05-10 17:35:12]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-13 12:28:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/20001

[commit-bot: I haz the power, 2013-05-13 13:02:14]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-13 13:44:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/37001

[commit-bot: I haz the power, 2013-05-13 13:44:06]

Can't process patch for file
LayoutTests/platform/chromium-linux/editing/style/unbold-in-bold-expected.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-05-13 14:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/40001

[commit-bot: I haz the power, 2013-05-13 14:55:54]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-15 15:51:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/40001

[commit-bot: I haz the power, 2013-05-15 16:36:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/14930006/55001

[commit-bot: I haz the power, 2013-05-15 17:41:13]

Change committed as 150444